Fix for Firefox which uses 'submit' as default button type. Closes a-…

…chernykh#18
mattbeedle · Apr 2, 2015 · 08d42e7 · 08d42e7
1 parent fd236f4
commit 08d42e7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/app/views/boxes/edit.html.slim b/app/views/boxes/edit.html.slim
@@ -7,4 +7,4 @@
     = token_tag nil
     = render layout: 'boxes/form', locals: { action: :update } do
         a.btn.pull-left.btn.btn-default.btn-lg href=box_url(@box) = t('.back')
-        button.pull-right.btn.btn-primary.btn-lg data-disable-with='Wait...' = t('.edit')
+        button.pull-right.btn.btn-primary.btn-lg type='submit' data-disable-with='Wait...' = t('.edit')
diff --git a/app/views/boxes/steps/_step3_environments.html.slim b/app/views/boxes/steps/_step3_environments.html.slim
@@ -86,7 +86,7 @@ a.anchor#environments
                         td
                           input.form-control type='number' placeholder='host port' ng-model='newHostPort'
                         td
-                          button.btn.btn-default ng-disabled='!newGuestPort || !newHostPort' ng-click='addPort()' Add
+                          button.btn.btn-default type='button' ng-disabled='!newGuestPort || !newHostPort' ng-click='addPort()' Add
 
             div ng-show="configuration[environment].target == 'server'"
               p.small SSH connection will be used to provision and deploy. Your default private key will be used to authenticate.

diff --git a/app/views/dashboard/show.html.slim b/app/views/dashboard/show.html.slim
@@ -20,4 +20,4 @@ a.anchor#home
     = token_tag nil
     = render layout: 'boxes/form' do
       div.alert.alert-danger role='alert' ng-hide='newBox.$valid' Please fix form errors first
-      button.btn.btn-default.btn-lg ng-disabled='!newBox.$valid' data-disable-with='Wait...' = t('.create')
+      button.btn.btn-default.btn-lg type='submit' ng-disabled='!newBox.$valid' data-disable-with='Wait...' = t('.create')
diff --git a/app/views/shared/_flash_messages.html.slim b/app/views/shared/_flash_messages.html.slim
@@ -1,4 +1,4 @@
 - flash.each do |type, message|
   div class="alert #{bootstrap_class_for(type)} fade in"
-    button class="close" data-dismiss="alert" ×
+    button type='button' class="close" data-dismiss="alert" ×
     = message