Skip to content

Commit

Permalink
video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings
Browse files Browse the repository at this point in the history
Fix following W=1 warnings:
- Fix set but not used variables that were used only for logging.
  Fixed by introducing no_printk() to trick compiler to think variables
  are used
- Fix kernel-doc warning by deleting an empty comment line

v3:
  - Fix grammar in commit message (Thomas)
v2:
  - Subject updated (Lee)

Signed-off-by: Sam Ravnborg <[email protected]>
Reviewed-by: Thomas Zimmermann <[email protected]>
Cc: Kristoffer Ericson <[email protected]>
Cc: Lee Jones <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
sravnborg committed Nov 29, 2020
1 parent b1cba76 commit 6fdf38e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/video/fbdev/s1d13xxxfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
#if 0
#define dbg(fmt, args...) do { printk(KERN_INFO fmt, ## args); } while(0)
#else
#define dbg(fmt, args...) do { } while (0)
#define dbg(fmt, args...) do { no_printk(KERN_INFO fmt, ## args); } while (0)
#endif

/*
Expand Down Expand Up @@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area)
}

/**
*
* s1d13xxxfb_bitblt_solidfill - accelerated solidfill function
* @info : framebuffer structure
* @rect : fb_fillrect structure
Expand Down

0 comments on commit 6fdf38e

Please sign in to comment.