Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically adjust mask branch according to MASK_SHAPE #1219

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

keineahnung2345
Copy link
Contributor

This PR makes MASK_SHAPE configurable, and the structure of mask branch will be adjusted accordingly.
It also adds assertion for easier debugging, ref: #331.

One can now set MASK_SHAPE as [28,28], [56,56], [112, 112], [224, 224], etc, given MASK_POOL_SIZE is 14.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@keineahnung2345 keineahnung2345 changed the title Configurable mask branch Automatically accadjust mask branchording to MASK_SHAPE Jan 11, 2019
@keineahnung2345 keineahnung2345 changed the title Automatically accadjust mask branchording to MASK_SHAPE Automatically adjust mask branch according to MASK_SHAPE Jan 11, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@waleedka waleedka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I really like this PR. I marked one issue that could cause a bug.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
luccauchon pushed a commit to luccauchon/Mask_RCNN that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants