Bump node-fetch from 1.7.3 to 2.6.1 #189
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 1.7.3 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@1.7.3...v2.6.1) Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
This is an important security release. It is strongly recommended to update as soon as possible. |
matthew-andrews
deleted the
dependabot/npm_and_yarn/node-fetch-2.6.1
branch
|
Has this update been published? |
|
@matthew-andrews would you be able to push this new change in a release to NPM? Our CI fails on |
|
@matthew-andrews please UPD. I use legacy project codebase, which currently use |
|
@alundiak it will be a breaking change so it will be 3.0.0 … but i haven't heard a single person confirm that they've tested it from the master branch and have found it to work properly for them … … … |
|
I agree with @alundiak it will need to be 2.2.2 if it is going to fix the issue with fbjs. Many react package use an older version of fbjs which uses isomorphic-fetch major version 2, so if you bump the major version than this will not be resolved. For example |
|
Looks like facebook team is hoping that you cut a 2.x patch for this issue: facebook/react#19840 (comment) |
|
I'm not very familiar with React … why wouldn't |
|
Also see discussion: facebook/react#19840 (comment) Its best if you do a 2.2.2 patch release |
Bumps node-fetch from 1.7.3 to 2.6.1.
Release notes
Sourced from node-fetch's releases.
Changelog
Sourced from node-fetch's changelog.
Commits
b5e2e41update version number2358a6cHonor thesizeoption after following a redirect and revert data uri support8c197f8docs: Fix typos and grammatical errors in README.md (#686)1e99050fix: Change error message thrown with redirect mode set to error (#653)244e6f6docs: Show backers in README6a5d192fix: Properly parse meta tag when parameters are reversed (#682)47a24a0chore: Add opencollective badge7b13662chore: Add funding link5535c2efix: Check for global.fetch before binding it (#674)1d5778adocs: Add Discord badgeMaintainer changes
This version was pushed to npm by akepinski, a new releaser for node-fetch since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.