-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies to the latest versions #69
Conversation
I don't think this does anything except potentially disrupt people who, for whatever reason, need to use old versions. The versions that you've updated to in I'd be happy to accept a pull request that just updated the |
@matthew-andrews I really need this merged: I bumped in this problem: facebook/react-native#5667 After a long day of research I realised that is related to this issue into the github fetch module: JakeChampion/fetch#125 And if you see the changelog of the the fetch repo you find that the bug was fixed on version 0.11.0: https://github.com/github/fetch/releases Would be nice to have this merged, otherwise I would need to fork of this project to use it :( |
@lucasfeliciano but the previous semver should allow Also I think the Have you tried this branch? |
That is exactly where the problem occurs in my current version. But this PR have the same fix that the whatwg-fetch made. |
So can I close this pull request? I don't think this pull request does anything except potentially break this module for other consumers…… |
The thing is, if you update the version of the Not 100% sure, because when I was forking to debug you replied me but yeah. I think it is better to update the dependency than make the same changes in this repo |
The semver constraint in the master branch for https://github.com/matthew-andrews/isomorphic-fetch/blob/master/bower.json#L5 This means that when you install this module you should get the latest version of whatwg-fetch. I have just checked this:- $ echo {} > package.json
$ npm install --save isomorphic-fetch
npm WARN package.json @ No description
npm WARN package.json @ No repository field.
npm WARN package.json @ No README data
[email protected] node_modules/isomorphic-fetch
├── [email protected]
└── [email protected] ([email protected]) ^^ it gets [email protected] |
Indeed, just checked this. So we need this ( https://github.com/matthew-andrews/isomorphic-fetch/pull/63/files ) merged. Just tested it and fix the problem |
All tests pass, what else can I say?
packages.json
bower.json