Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix syntax error #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

a-skua
Copy link
Contributor

@a-skua a-skua commented Jan 28, 2022

I fixed syntax errors for attr or text when used id or class, and fixed mistake test case.

form#form-box method="post"

label.form-label for="your-name" Your Name
- syntax error: method="post"
+ <form id="form-box" method="post">
+ </form>

- syntax error: for="your-name" Your Name
+ <label class="form-label" for="your-name">Your Name</label>

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.80%. Comparing base (4a5a951) to head (565d43c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   58.76%   59.80%   +1.03%     
==========================================
  Files           6        6              
  Lines         810      816       +6     
==========================================
+ Hits          476      488      +12     
+ Misses        282      279       -3     
+ Partials       52       49       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattn
Copy link
Owner

mattn commented Jan 2, 2024

Sorry, I missed this PR. Could you please rebase master?

@a-skua a-skua force-pushed the bugfix/syntax_error branch from 83d8e4a to 565d43c Compare January 8, 2024 04:11
@a-skua
Copy link
Contributor Author

a-skua commented Jan 8, 2024

@mattn
Thank you. I have rebased, so please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants