Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use biomejs as linter + formatter #478

Merged
merged 10 commits into from
Jun 26, 2024
Merged

build: use biomejs as linter + formatter #478

merged 10 commits into from
Jun 26, 2024

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Jun 15, 2024 •
edited
Loading

Proposing to use biomejs.dev as an all-in-one linter and formatter

@setchy setchy changed the title build: switch to biomejs as linter + formatter build: use biomejs as linter + formatter Jun 15, 2024
amaury1093
amaury1093 reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to use biome, I anyways wanted to remove dependency on my own packages @amaurym/{config,typescript,eslint}

package.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@setchy setchy requested a review from amaury1093 June 25, 2024 16:59
@setchy
Copy link
Contributor Author

setchy commented Jun 25, 2024 •
edited
Loading

@amaury1093 - feedback incorporated.

@setchy setchy mentioned this pull request Jun 25, 2024
Open
amaury1093
amaury1093 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will merge once the conflict is resolved.

@setchy setchy requested a review from amaury1093 June 26, 2024 09:44
@amaury1093 amaury1093 merged commit 5d6ef01 into max-mapper:master Jun 26, 2024
2 checks passed
@setchy setchy deleted the build/use-biomejs branch June 26, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @amaury1093