Skip to content

Commit

Permalink
bpo-26978: Implement pathlib.Path.link_to (Using os.link) (pythonGH-1…
Browse files Browse the repository at this point in the history
  • Loading branch information
nanjekyejoannah authored and pitrou committed May 4, 2019
1 parent f090019 commit 6b5b013
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 0 deletions.
7 changes: 7 additions & 0 deletions Doc/library/pathlib.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1054,6 +1054,13 @@ call fails (for example because the path doesn't exist).
use :func:`Path.rmdir` instead.


.. method:: Path.link_to(target)

Create a hard link pointing to a path named *target*.

.. versionchanged:: 3.8


.. method:: Path.write_bytes(data)

Open the file pointed to in bytes mode, write *data* to it, and close the
Expand Down
4 changes: 4 additions & 0 deletions Doc/whatsnew/3.8.rst
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,10 @@ pathlib
contain characters unrepresentable at the OS level.
(Contributed by Serhiy Storchaka in :issue:`33721`.)

Added :meth:`pathlib.Path.link_to()` which creates a hard link pointing
to a path.
(Contributed by Joannah Nanjekye in :issue:`26978`)


socket
------
Expand Down
10 changes: 10 additions & 0 deletions Lib/pathlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,8 @@ def lchmod(self, pathobj, mode):

unlink = os.unlink

link_to = os.link

rmdir = os.rmdir

rename = os.rename
Expand Down Expand Up @@ -1303,6 +1305,14 @@ def lstat(self):
self._raise_closed()
return self._accessor.lstat(self)

def link_to(self, target):
"""
Create a hard link pointing to a path named target.
"""
if self._closed:
self._raise_closed()
self._accessor.link_to(self, target)

def rename(self, target):
"""
Rename this path to the given path.
Expand Down
19 changes: 19 additions & 0 deletions Lib/test/test_pathlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1643,6 +1643,25 @@ def test_rmdir(self):
self.assertFileNotFound(p.stat)
self.assertFileNotFound(p.unlink)

def test_link_to(self):
P = self.cls(BASE)
p = P / 'fileA'
size = p.stat().st_size
# linking to another path.
q = P / 'dirA' / 'fileAA'
try:
p.link_to(q)
except PermissionError as e:
self.skipTest('os.link(): %s' % e)
self.assertEqual(q.stat().st_size, size)
self.assertEqual(os.path.samefile(p, q), True)
self.assertTrue(p.stat)
# Linking to a str of a relative path.
r = rel_join('fileAAA')
q.link_to(r)
self.assertEqual(os.stat(r).st_size, size)
self.assertTrue(q.stat)

def test_rename(self):
P = self.cls(BASE)
p = P / 'fileA'
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
`pathlib.path.link_to()` is now implemented. It creates a hard link pointing
to a path.

0 comments on commit 6b5b013

Please sign in to comment.