Change verifier to only run read-only queries by default

Running write or destructive queries is dangerous, so make it opt-in
maxid · Apr 18, 2016 · 1011879 · 1011879
1 parent 737ba20
commit 1011879
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/presto-verifier/src/main/java/com/facebook/presto/verifier/VerifierConfig.java b/presto-verifier/src/main/java/com/facebook/presto/verifier/VerifierConfig.java
@@ -31,8 +31,6 @@
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
 
-import static com.facebook.presto.verifier.QueryType.CREATE;
-import static com.facebook.presto.verifier.QueryType.MODIFY;
 import static com.facebook.presto.verifier.QueryType.READ;
 import static java.util.Objects.requireNonNull;
 
@@ -43,8 +41,8 @@ public class VerifierConfig
     private String testPasswordOverride;
     private String controlPasswordOverride;
     private List<String> suites;
-    private Set<QueryType> controlQueryTypes = ImmutableSet.of(CREATE, READ, MODIFY);
-    private Set<QueryType> testQueryTypes = ImmutableSet.of(CREATE, READ, MODIFY);
+    private Set<QueryType> controlQueryTypes = ImmutableSet.of(READ);
+    private Set<QueryType> testQueryTypes = ImmutableSet.of(READ);
     private String source;
     private String runId = new DateTime().toString("yyyy-MM-dd");
     private Set<String> eventClients = ImmutableSet.of("human-readable");

diff --git a/presto-verifier/src/test/java/com/facebook/presto/verifier/TestVerifierConfig.java b/presto-verifier/src/test/java/com/facebook/presto/verifier/TestVerifierConfig.java
@@ -39,8 +39,8 @@ public void testDefaults()
                 .setControlPasswordOverride(null)
                 .setSuite(null)
                 .setSuites(null)
-                .setControlQueryTypes(Joiner.on(",").join(CREATE, READ, MODIFY))
-                .setTestQueryTypes(Joiner.on(",").join(CREATE, READ, MODIFY))
+                .setControlQueryTypes(READ.name())
+                .setTestQueryTypes(READ.name())
                 .setSource(null)
                 .setRunId(new DateTime().toString("yyyy-MM-dd"))
                 .setEventClients("human-readable")
@@ -82,7 +82,7 @@ public void testExplicitPropertyMappings()
         Map<String, String> properties = new ImmutableMap.Builder<String, String>()
                 .put("suites", "my_suite")
                 .put("suite", "my_suite")
-                .put("control.query-types", READ.name())
+                .put("control.query-types", Joiner.on(",").join(CREATE, READ))
                 .put("test.query-types", MODIFY.name())
                 .put("source", "my_source")
                 .put("run-id", "my_run_id")
@@ -126,7 +126,7 @@ public void testExplicitPropertyMappings()
         VerifierConfig expected = new VerifierConfig().setTestUsernameOverride("verifier-test")
                 .setSuites("my_suite")
                 .setSuite("my_suite")
-                .setControlQueryTypes(READ.name())
+                .setControlQueryTypes(Joiner.on(",").join(CREATE, READ))
                 .setTestQueryTypes(MODIFY.name())
                 .setSource("my_source")
                 .setRunId("my_run_id")