Skip to content

Commit

Permalink
cleanup(core): hyphenate npm script names (nrwl#3672)
Browse files Browse the repository at this point in the history
separate words in npm scripts with hyphen for consistency
  • Loading branch information
vivekmore authored Oct 2, 2020
1 parent e339ece commit b04158b
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ jobs:
command: yarn documentation
- run:
name: Check Imports
command: yarn checkimports
command: yarn check-imports
- run:
name: Check Formatting
command: yarn checkformat
command: yarn check-format
- run:
name: Check Commit Message Format
command: yarn checkcommit
command: yarn check-commit
- run:
name: Run linting
command: yarn lint
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ Please follow the following guidelines:
- Make sure you run `yarn format`
- Update documentation with `yarn documentation`. For documentation, check for spelling and grammatical errors.
- Update your commit message to follow the guidelines below (use `yarn commit` to automate compliance)
- `yarn checkcommit` will check to make sure your commit messages are formatted correctly
- `yarn check-commit` will check to make sure your commit messages are formatted correctly

#### Commit Message Guidelines

Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@
"scripts": {
"build": "./scripts/package.sh --local",
"commit": "git-cz",
"checkcommit": "node ./scripts/commit-lint.js",
"check-commit": "node ./scripts/commit-lint.js",
"check-format": "scripts/check-format.sh",
"check-imports": "node ./scripts/check-imports.js",
"check-versions": "ts-node -P ./scripts/tsconfig.scripts.json ./scripts/check-versions.ts",
"e2e": "./scripts/e2e.sh",
"e2e-ci": "./scripts/e2e-ci.sh",
"format": "./scripts/format.sh",
"nx-release": "./scripts/nx-release.js",
"test": "nx run-many --target=test --all --parallel",
"lint": "nx run-many --target=lint --all --parallel",
"checkformat": "scripts/check-format.sh",
"checkimports": "node ./scripts/check-imports.js",
"checkversions": "ts-node -P ./scripts/tsconfig.scripts.json ./scripts/check-versions.ts",
"depcheck": "ts-node -P ./scripts/tsconfig.scripts.json ./scripts/depcheck.ts",
"local-registry": "./scripts/local-registry.sh",
"documentation": "./scripts/documentation/documentation.sh && ./scripts/documentation/check-documentation.sh",
Expand Down Expand Up @@ -251,7 +251,7 @@
},
"husky": {
"hooks": {
"pre-push": "yarn checkcommit && yarn documentation && pretty-quick --check"
"pre-push": "yarn check-commit && yarn documentation && pretty-quick --check"
}
}
}
4 changes: 2 additions & 2 deletions scripts/check-versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
* It uses naming conventions to transform constants to matching node module name.
*
* Usage:
* yarn checkversions [file]
* yarn check-versions [file]
*
* Positional arg:
* - [file]: relative or absolute file path to the versions file.
*
* Example:
* yarn checkversions packages/react/src/utils/versions
* yarn check-versions packages/react/src/utils/versions
*/

import { join } from 'path';
Expand Down

0 comments on commit b04158b

Please sign in to comment.