Skip to content

Commit

Permalink
Remove obsolete workaround for ESP8266 in compilation test CI workflow (
Browse files Browse the repository at this point in the history
arduino-libraries#38)

The ESP8266 platform has a tool dependency on python3, but assumes that tool is already installed in a particular location on Linux. At the time this workaround was added, the Docker container used by the arduino/actions/libraries/compile-examples action did not provide this tool, so a workaround was needed to install it in the container. Since that time, the action has developed a dependency on Python, making this workaround unnecessary. The switch from the action being a Bash script to a Python script caused the now-unnecessary workaround to break the workflow.
  • Loading branch information
per1234 authored May 29, 2020
1 parent 4f855f2 commit 6f4b6f0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/compile-examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,7 @@ jobs:
with:
fetch-depth: 1
- name: compile-examples for official Arduino boards
if: startsWith(matrix.fqbn, '"esp8266:esp8266') != true
uses: arduino/actions/libraries/compile-examples@master
with:
fqbn: ${{ matrix.fqbn }}
libraries: ${{ env.LIBRARIES }}
- name: compile-examples for ESP8266 boards
if: startsWith(matrix.fqbn, '"esp8266:esp8266')
uses: arduino/actions/libraries/compile-examples@master
with:
fqbn: ${{ matrix.fqbn }}
entrypoint: /github/workspace/.github/workflows/install-python-wrapper.sh
9 changes: 0 additions & 9 deletions .github/workflows/install-python-wrapper.sh

This file was deleted.

0 comments on commit 6f4b6f0

Please sign in to comment.