Skip to content

Commit

Permalink
Cygwin build not to use -fPIC
Browse files Browse the repository at this point in the history
Summary:
Cygwin doesn't support -fPIC. Remove it.
Not sure whether we can build shared library in Cygwin but at least it can build without warning.

Test Plan: Build under Cygwin

Reviewers: yhchiang, rven, kradhakrishnan, igor

Reviewed By: igor

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D40077
  • Loading branch information
siying committed Jun 12, 2015
1 parent bee8d03 commit 46296cc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions build_tools/build_detect_platform
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ case "$TARGET_OS" in
;;
Cygwin)
PLATFORM=CYGWIN
PLATFORM_SHARED_CFLAGS=""
PLATFORM_CXXFLAGS="-std=gnu++11"
COMMON_FLAGS="$COMMON_FLAGS -DCYGWIN"
if [ -z "$USE_CLANG" ]; then
Expand Down

0 comments on commit 46296cc

Please sign in to comment.