KNL-1298 Allow subclasses of ResourceLoader for easier testing.

By making the service locators non-static subclasses can be created for tests which change how the dependencies are found.
mbideas · Jan 20, 2015 · e84f931 · e84f931
1 parent 3d104b5
commit e84f931
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/kernel/kernel-util/src/main/java/org/sakaiproject/util/ResourceLoader.java b/kernel/kernel-util/src/main/java/org/sakaiproject/util/ResourceLoader.java
@@ -80,7 +80,7 @@ public String getUserId() {
 	private final static Object LOCK = new Object();
 
 	private static SessionManager sessionManager;
-	protected static SessionManager getSessionManager() {
+	protected SessionManager getSessionManager() {
         if (sessionManager == null) {
             synchronized (LOCK) {
                 sessionManager = (SessionManager) ComponentManager.get(SessionManager.class);
@@ -90,7 +90,7 @@ protected static SessionManager getSessionManager() {
 	}
 
 	private static PreferencesService preferencesService;
-	protected static PreferencesService getPreferencesService() {
+	protected PreferencesService getPreferencesService() {
 	    if (preferencesService == null) {
 	        synchronized (LOCK) {
 	            preferencesService = (PreferencesService) ComponentManager.get(PreferencesService.class);