Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: [🍎💳] Fix intermittent API test failures
I believe the root cause of the flaky tests is the fact that we reusetrip_id
s across test modules. This causes some logic to include the wrong model in the returned map. In each test module, I changed thetrip_id
s to be unique to the module.Even after the above change, tests were still intermittently failing. Decided to explore ways to ensure fresh state before each test. Found that stopping and starting the State app before each test allows for more predictable state in each process.