Skip to content

Commit

Permalink
Remove "no_ubsan" tags that are no longer needed.
Browse files Browse the repository at this point in the history
Signed-off-by: Chris Lalancette <[email protected]>
  • Loading branch information
clalancette committed Dec 20, 2017
1 parent 38a80b2 commit c2fdfaa
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 38 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,8 @@ drake_cc_binary(
],
# TODO(m-chaturvedi) TSan fails with a data race in LCM for this test. See
# #7524.
# TODO(clalancette) UBSan fails due to a bug in Protobuf 2.6 (the
# workaround in later versions of Protobuf is described here:
# https://github.com/google/protobuf/blob/master/src/google/protobuf/generated_message_util.h#L78
# In the future we should add a codegen action to edit the generated file
# include block to add a fixup header with the workaround at the end.
tags = [
"no_tsan",
"no_ubsan",
],
test_rule_args = ["--quick"],
# Flaky because LCM self-test can fail (PR #7311)
Expand Down
8 changes: 0 additions & 8 deletions examples/kuka_iiwa_arm/dev/pick_and_place/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,6 @@ drake_cc_googletest(
"//drake/examples/kuka_iiwa_arm:models",
"//drake/manipulation/models/iiwa_description:models",
],
# TODO(clalancette) UBSan fails due to a bug in Protobuf 2.6 (the
# workaround in later versions of Protobuf is described here:
# https://github.com/google/protobuf/blob/master/src/google/protobuf/generated_message_util.h#L78
# In the future we should add a codegen action to edit the generated file
# include block to add a fixup header with the workaround at the end.
tags = [
"no_ubsan",
],
deps = [
"//drake/common/test_utilities:eigen_matrix_compare",
"//drake/examples/kuka_iiwa_arm/dev/pick_and_place:pick_and_place_configuration_parsing", # noqa
Expand Down
8 changes: 0 additions & 8 deletions multibody/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -589,14 +589,6 @@ drake_cc_googletest(
"test/test.alias_groups",
"//drake/multibody:test_models",
],
# TODO(clalancette) UBSan fails due to a bug in Protobuf 2.6 (the
# workaround in later versions of Protobuf is described here:
# https://github.com/google/protobuf/blob/master/src/google/protobuf/generated_message_util.h#L78
# In the future we should add a codegen action to edit the generated file
# include block to add a fixup header with the workaround at the end.
tags = [
"no_ubsan",
],
deps = [
":rigid_body_tree_alias_groups",
"//drake/common:find_resource",
Expand Down
8 changes: 0 additions & 8 deletions systems/controllers/plan_eval/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,6 @@ drake_cc_googletest(
"//drake/systems/controllers/qp_inverse_dynamics:test/iiwa.alias_groups", # noqa
"//drake/systems/controllers/qp_inverse_dynamics:test/iiwa.id_controller_config", # noqa
],
# TODO(clalancette) UBSan fails due to a bug in Protobuf 2.6 (the
# workaround in later versions of Protobuf is described here:
# https://github.com/google/protobuf/blob/master/src/google/protobuf/generated_message_util.h#L78
# In the future we should add a codegen action to edit the generated file
# include block to add a fixup header with the workaround at the end.
tags = [
"no_ubsan",
],
deps = [
":generic_plan",
":test_common",
Expand Down
8 changes: 0 additions & 8 deletions systems/controllers/qp_inverse_dynamics/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,6 @@ drake_cc_googletest(
"test/params.id_controller_config",
"//drake/examples/valkyrie:models",
],
# TODO(clalancette) UBSan fails due to a bug in Protobuf 2.6 (the
# workaround in later versions of Protobuf is described here:
# https://github.com/google/protobuf/blob/master/src/google/protobuf/generated_message_util.h#L78
# In the future we should add a codegen action to edit the generated file
# include block to add a fixup header with the workaround at the end.
tags = [
"no_ubsan",
],
deps = [
":param_parser",
"//drake/common:find_resource",
Expand Down

0 comments on commit c2fdfaa

Please sign in to comment.