Skip to content

Commit

Permalink
Make DrakeLcmParams an aggregate for C++20 (RobotLocomotion#17845)
Browse files Browse the repository at this point in the history
This type is constructed as an aggregate in drake_lcm.cc. However, because
there are constructors, the type is not actually an aggregate causing "error:
no matching constructor for initialization of drake::lcm::DrakeLcmParams"
when compiling in C++20 mode.
  • Loading branch information
alexkaratarakis authored Sep 6, 2022
1 parent 78eaea8 commit ec984ce
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
1 change: 0 additions & 1 deletion lcm/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ drake_cc_library(

drake_cc_library(
name = "drake_lcm_params",
srcs = ["drake_lcm_params.cc"],
hdrs = ["drake_lcm_params.h"],
deps = [
"//common:essential",
Expand Down
9 changes: 0 additions & 9 deletions lcm/drake_lcm_params.cc

This file was deleted.

4 changes: 0 additions & 4 deletions lcm/drake_lcm_params.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ namespace lcm {

/** The set of parameters for configuring DrakeLcm. */
struct DrakeLcmParams {
DRAKE_DEFAULT_COPY_AND_MOVE_AND_ASSIGN(DrakeLcmParams)
DrakeLcmParams() = default;
~DrakeLcmParams();

/** Passes this object to an Archive.
Refer to @ref yaml_serialization "YAML Serialization" for background. */
template <typename Archive>
Expand Down

0 comments on commit ec984ce

Please sign in to comment.