Remove obsecure Machinery 'result' field from job status response.

mdasifj625 · Mar 13, 2024 · 3453e21 · 3453e21
1 parent 2af83ff
commit 3453e21
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/internal/core/core.go b/internal/core/core.go
@@ -187,10 +187,9 @@ func (co *Core) GetJobStatus(jobID string) (models.JobStatusResp, error) {
 	}
 
 	return models.JobStatusResp{
-		JobID:   out.TaskUUID,
-		State:   out.State,
-		Results: out.Results,
-		Error:   out.Error,
+		JobID: out.TaskUUID,
+		State: out.State,
+		Error: out.Error,
 	}, nil
 }
 
@@ -213,10 +212,9 @@ func (co *Core) GetJobGroupStatus(groupID string) (models.GroupStatusResp, error
 	)
 	for i, j := range res {
 		jobs[i] = models.JobStatusResp{
-			JobID:   j.TaskUUID,
-			State:   j.State,
-			Results: j.Results,
-			Error:   j.Error,
+			JobID: j.TaskUUID,
+			State: j.State,
+			Error: j.Error,
 		}
 
 		if j.State == tasks.StateSuccess {

diff --git a/models/models.go b/models/models.go
@@ -2,8 +2,6 @@ package models
 
 import (
 	"time"
-
-	"github.com/RichardKnop/machinery/v1/tasks"
 )
 
 // JobReq represents a job request.
@@ -31,10 +29,9 @@ type JobResp struct {
 
 // JobStatusResp represents the response of a single job.
 type JobStatusResp struct {
-	JobID   string              `json:"job_id"`
-	State   string              `json:"state"`
-	Results []*tasks.TaskResult `json:"results"`
-	Error   string              `json:"error"`
+	JobID string `json:"job_id"`
+	State string `json:"state"`
+	Error string `json:"error"`
 }
 
 // GroupReq represents a Jobrequest group.