test(testrunner): fix the 'timeout: 0' test runner setting (puppeteer…

…#1561)
mdomke · Dec 9, 2017 · fc1f15e · fc1f15e
1 parent 391d1ab
commit fc1f15e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/utils/testrunner/TestRunner.js b/utils/testrunner/TestRunner.js
@@ -34,8 +34,6 @@ class UserCallback {
 
   async run(...args) {
     const timeoutPromise = new Promise(resolve => {
-      if (!this.timeout)
-        return;
       setTimeout(resolve.bind(null, TimeoutError), this.timeout);
     });
     try {
@@ -264,7 +262,8 @@ class TestRunner extends EventEmitter {
     this._rootSuite = new Suite(null, '', TestMode.Run);
     this._currentSuite = this._rootSuite;
     this._tests = [];
-    this._timeout = options.timeout || 10 * 1000; // 10 seconds.
+    // Default timeout is 10 seconds.
+    this._timeout = options.timeout === 0 ? 2147483647 : options.timeout ||  10 * 1000;
     this._parallel = options.parallel || 1;
     this._retryFailures = !!options.retryFailures;