Add function to initialize set from elements (ava-labs#1808)

api/health/worker.go

@@ -146,8 +146,7 @@ func (w *worker) Results(tags ...string) (map[string]Result, bool) {
 	}
 
 	names := set.Set[string]{}
-	tagSet := set.NewSet[string](len(tags) + 1)
-	tagSet.Add(tags...)
+	tagSet := set.Of(tags...)
 	tagSet.Add(ApplicationTag) // we always want to include the application tag
 	for tag := range tagSet {
 		if set, ok := w.tags[tag]; ok {

network/network_test.go

@@ -374,9 +374,8 @@ func TestSendAndGossipWithFilter(t *testing.T) {
 	outboundGetMsg, err := mc.Get(ids.Empty, 1, time.Second, ids.Empty, p2p.EngineType_ENGINE_TYPE_SNOWMAN)
 	require.NoError(err)
 
-	toSend := set.NewSet[ids.NodeID](3)
+	toSend := set.Of(nodeIDs...)
 	validNodeID := nodeIDs[1]
-	toSend.Add(nodeIDs...)
 	sentTo := net0.Send(outboundGetMsg, toSend, constants.PrimaryNetworkID, newNodeIDConnector(validNodeID))
 	require.Len(sentTo, 1)
 	require.Contains(sentTo, validNodeID)

network/p2p/client.go

@@ -59,9 +59,7 @@ func (c *Client) AppRequestAny(
 		return ErrNoPeers
 	}
 
-	nodeIDs := set.Set[ids.NodeID]{
-		peers[0]: struct{}{},
-	}
+	nodeIDs := set.Of(peers[0])
 	return c.AppRequest(ctx, nodeIDs, appRequestBytes, onResponse)
 }
 
@@ -89,7 +87,7 @@ func (c *Client) AppRequest(
 
 		if err := c.sender.SendAppRequest(
 			ctx,
-			set.Set[ids.NodeID]{nodeID: struct{}{}},
+			set.Of(nodeID),
 			requestID,
 			appRequestBytes,
 		); err != nil {

network/p2p/router_test.go

@@ -85,7 +85,7 @@ func TestAppRequestResponse(t *testing.T) {
 					require.Nil(t, actualResponse)
 				}
 
-				require.NoError(t, client.AppRequest(context.Background(), set.Set[ids.NodeID]{nodeID: struct{}{}}, request, callback))
+				require.NoError(t, client.AppRequest(context.Background(), set.Of(nodeID), request, callback))
 			},
 		},
 		{
@@ -179,7 +179,7 @@ func TestAppRequestResponse(t *testing.T) {
 						return nil
 					})
 
-				require.NoError(t, client.AppGossipSpecific(context.Background(), set.Set[ids.NodeID]{nodeID: struct{}{}}, request))
+				require.NoError(t, client.AppGossipSpecific(context.Background(), set.Of(nodeID), request))
 			},
 		},
 	}
@@ -333,13 +333,13 @@ func TestAppRequestDuplicateRequestIDs(t *testing.T) {
 	client, err := router.RegisterAppProtocol(0x1, handler)
 	require.NoError(err)
 
-	require.NoError(client.AppRequest(context.Background(), set.Set[ids.NodeID]{nodeID: struct{}{}}, []byte{}, nil))
+	require.NoError(client.AppRequest(context.Background(), set.Of(nodeID), []byte{}, nil))
 	requestSent.Wait()
 
 	// force the router to use the same requestID
 	router.requestID = 0
 	timeout.Add(1)
-	err = client.AppRequest(context.Background(), set.Set[ids.NodeID]{nodeID: struct{}{}}, []byte{}, nil)
+	err = client.AppRequest(context.Background(), set.Of(nodeID), []byte{}, nil)
 	requestSent.Wait()
 	require.ErrorIs(err, ErrRequestPending)
 

network/peer/peer_test.go

@@ -265,8 +265,7 @@ func TestPingUptimes(t *testing.T) {
 	trackedSubnetID := ids.GenerateTestID()
 	untrackedSubnetID := ids.GenerateTestID()
 
-	trackedSubnets := set.NewSet[ids.ID](1)
-	trackedSubnets.Add(trackedSubnetID)
+	trackedSubnets := set.Of(trackedSubnetID)
 
 	mc := newMessageCreator(t)
 

snow/engine/avalanche/bootstrap/bootstrapper_test.go

@@ -389,10 +389,8 @@ func TestBootstrapperTxDependencies(t *testing.T) {
 			IDV:     txID1,
 			StatusV: choices.Processing,
 		},
-		DependenciesV: set.Set[ids.ID]{
-			innerTx0.IDV: struct{}{},
-		},
-		BytesV: txBytes1,
+		DependenciesV: set.Of(innerTx0.IDV),
+		BytesV:        txBytes1,
 	}
 
 	tx0 := &testTx{

snow/engine/common/queue/jobs_test.go

@@ -32,7 +32,7 @@ func testJob(t *testing.T, jobID ids.ID, executed *bool, parentID ids.ID, parent
 		},
 		MissingDependenciesF: func(context.Context) (set.Set[ids.ID], error) {
 			if parentID != ids.Empty && !*parentExecuted {
-				return set.Set[ids.ID]{parentID: struct{}{}}, nil
+				return set.Of(parentID), nil
 			}
 			return set.Set[ids.ID]{}, nil
 		},

snow/engine/snowman/transitive.go

@@ -704,8 +704,7 @@ func (t *Transitive) pullQuery(ctx context.Context, blkID ids.ID) {
 	t.RequestID++
 	if t.polls.Add(t.RequestID, vdrBag) {
 		vdrList := vdrBag.List()
-		vdrSet := set.NewSet[ids.NodeID](len(vdrList))
-		vdrSet.Add(vdrList...)
+		vdrSet := set.Of(vdrList...)
 		t.Sender.SendPullQuery(ctx, vdrSet, t.RequestID, blkID)
 	}
 }
@@ -735,8 +734,7 @@ func (t *Transitive) sendQuery(ctx context.Context, blk snowman.Block, push bool
 	t.RequestID++
 	if t.polls.Add(t.RequestID, vdrBag) {
 		vdrs := vdrBag.List()
-		sendTo := set.NewSet[ids.NodeID](len(vdrs))
-		sendTo.Add(vdrs...)
+		sendTo := set.Of(vdrs...)
 
 		if push {
 			t.Sender.SendPushQuery(ctx, sendTo, t.RequestID, blk.Bytes())

snow/networking/router/chain_router_test.go

@@ -1547,8 +1547,7 @@ func TestValidatorOnlyAllowedNodeMessageDrops(t *testing.T) {
 
 	ctx := snow.DefaultConsensusContextTest()
 	allowedID := ids.GenerateTestNodeID()
-	allowedSet := set.NewSet[ids.NodeID](1)
-	allowedSet.Add(allowedID)
+	allowedSet := set.Of(allowedID)
 	sb := subnets.New(ctx.NodeID, subnets.Config{ValidatorOnly: true, AllowedNodes: allowedSet})
 
 	vdrs := validators.NewSet()

snow/networking/sender/sender.go

@@ -207,8 +207,7 @@ func (s *sender) SendStateSummaryFrontier(ctx context.Context, nodeID ids.NodeID
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,
@@ -351,8 +350,7 @@ func (s *sender) SendAcceptedStateSummary(ctx context.Context, nodeID ids.NodeID
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,
@@ -487,8 +485,7 @@ func (s *sender) SendAcceptedFrontier(ctx context.Context, nodeID ids.NodeID, re
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,
@@ -621,8 +618,7 @@ func (s *sender) SendAccepted(ctx context.Context, nodeID ids.NodeID, requestID
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,
@@ -702,8 +698,7 @@ func (s *sender) SendGetAncestors(ctx context.Context, nodeID ids.NodeID, reques
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,
@@ -742,8 +737,7 @@ func (s *sender) SendAncestors(_ context.Context, nodeID ids.NodeID, requestID u
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,
@@ -817,8 +811,7 @@ func (s *sender) SendGet(ctx context.Context, nodeID ids.NodeID, requestID uint3
 	// Send the message over the network.
 	var sentTo set.Set[ids.NodeID]
 	if err == nil {
-		nodeIDs := set.NewSet[ids.NodeID](1)
-		nodeIDs.Add(nodeID)
+		nodeIDs := set.Of(nodeID)
 		sentTo = s.sender.Send(
 			outMsg,
 			nodeIDs,
@@ -869,8 +862,7 @@ func (s *sender) SendPut(_ context.Context, nodeID ids.NodeID, requestID uint32,
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,
@@ -1185,8 +1177,7 @@ func (s *sender) SendChits(ctx context.Context, nodeID ids.NodeID, requestID uin
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,
@@ -1413,8 +1404,7 @@ func (s *sender) SendAppResponse(ctx context.Context, nodeID ids.NodeID, request
 	}
 
 	// Send the message over the network.
-	nodeIDs := set.NewSet[ids.NodeID](1)
-	nodeIDs.Add(nodeID)
+	nodeIDs := set.Of(nodeID)
 	sentTo := s.sender.Send(
 		outMsg,
 		nodeIDs,