-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement quickxml support #31
base: main
Are you sure you want to change the base?
Conversation
They are not supported by quick-xml/serde
Using plural can go wrong when the field name has an irregular plural, like matrix.
quick-xml/serde have no support for prefixes.
Hi @matzipan I have look your PR. It's a great work. For the support of quick-xml, I'm not opposite. So my suggestion is to create features in xml-schema named Does it make sense for you ? |
Makes sense. |
quick-xml implements this natively
Hi,
I'm not sure if quick-xml/serde support is something that you are interested in upstream. Just wanted to open this MR to show some of the early work that I am doing to create serde/quick-xml compatible type definitions. Feel free to close this merge request if it's not a direction that you want to take.
quick-xml of course does not support namespaces so for now I just nerfed the definition and just ignored the parameter.
One change which is not strictly related is a64a146. The reason for this is that you can have a lot of nouns with irregular plural like matrix -> matrices, so adding "s" is not the best default to have. I can submit this as a separate MR if it's interesting upstream.
So far I was able to parse XMLs with these descriptions: ttps://sanaregistry.org/files/ndmxml_unqualified/ndmxml-3.0.0-omm-3.0.xsd and ttps://sanaregistry.org/files/ndmxml_unqualified/ndmxml-3.0.0-common-3.0.xsd The parsing has been partial due to some missing things like group, and possible choice so I have to look at that next.