close #6 feature to terminate job earlier #17
Conversation
|
@dmitri-carpov please break the commit into smaller bites, otherwise it would be difficult for me to review |
| @@ -1,11 +1,11 @@ | |||
| # Error Handling | |||
| ### Error Handling | |||
There was a problem hiding this comment.
This should be a top-level heading
|
Most changes are from updating the license header |
dmitri-carpov
force-pushed
the
dmitri/6-terminate-job-earlier
branch
2 times, most recently
from
397980e to
cad5cc8
Compare
|
@dmitri-carpov looks good (:+1: from me). that being said, since this feature is blocking a few items i think it would be worthwhile for @WadeWaldron also takes a brief look to vet things |
|
Minor nit: new code doesn't use |
|
|
||
| akka { | ||
| log-dead-letters = 0 | ||
| loglevel = "ERROR" |
There was a problem hiding this comment.
I wonder if this should be changed to "WARNING"?
There was a problem hiding this comment.
eigenflow uses warnings to report retries, what produces too much noise during testing.
we could potentially improve it by setting log level only for eigenflow package.
There was a problem hiding this comment.
Ah sorry, I didn't realize this was in the "it" resources.
Also, did you mean "eigenflow uses warnings to report retries"? That would seem more appropriate.
There was a problem hiding this comment.
yes, warnings :)
dmitri-carpov
force-pushed
the
dmitri/6-terminate-job-earlier
branch
from
6e0df34 to
a79a6ca
Compare
close #6 feature to terminate job earlier
No description provided.