Skip to content

Commit

Permalink
Fixed tests
Browse files Browse the repository at this point in the history
Fixed by moving the getResolvers method to separate test, since setServers doesn't play well with async code: see node/issues/1071 this will be fixed in node 8
  • Loading branch information
Filippo Conti committed Oct 26, 2017
1 parent 5f8a181 commit 7d773ad
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
16 changes: 16 additions & 0 deletions __tests__/resolvers.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
var subquest = require('../index.js')

describe('Resolvers method', function() {
describe('adds a user defined DNS server to the stack', function() {
it('returns user defined DNS server as first', function(done) {
// Custom DNS server
let customDNS = '91.239.100.100'

// Get resolvers list by adding valid provided server
subquest.getResolvers(customDNS, function(result) {
expect(result[0]).toBe(customDNS)
done()
})
})
})
})
14 changes: 0 additions & 14 deletions __tests__/servers.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ describe('DNS Servers', function() {
})
})


describe('test invalid DNS server before adding to resolvers', function() {

// List of invalid servers
Expand All @@ -33,17 +32,4 @@ describe('DNS Servers', function() {
})
})
})

describe('adds a user defined DNS server to the stack', function() {
it('returns user defined DNS server as first', function(done) {
// Custom DNS server
let customDNS = '91.239.100.100'

// Get resolvers list by adding valid provided server
subquest.getResolvers(customDNS, function(result) {
expect(result[0]).toBe(customDNS)
done()
})
})
})
})

0 comments on commit 7d773ad

Please sign in to comment.