Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to disable animation for Thing #1021

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

nekiro
Copy link
Collaborator

@nekiro nekiro commented Jan 6, 2025

Description

Allow to disable animation for all classes inheriting from Thing, ex: Effect, Item, Creature

thing = g_ui.createWidget("UIItem")
thing:getItem():setAnimate(false)

UIItem etc could also receive setAnimate(), but for simplicity I didn't add them.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@nekiro nekiro force-pushed the allow-disable-animation branch from df74e14 to fd5959f Compare January 6, 2025 14:30
@nekiro nekiro changed the title Allow disable animation for Thing Allow to disable animation for Thing Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

@mehah mehah changed the title Allow to disable animation for Thing feat: allow to disable animation for Thing Jan 6, 2025
@mehah mehah merged commit f29cbfd into main Jan 6, 2025
12 checks passed
@mehah mehah deleted the allow-disable-animation branch January 6, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants