Skip to content

Commit

Permalink
ci: always lint with types
Browse files Browse the repository at this point in the history
use new EXPERIMENTAL_useProjectService which makes this performant enough to use
  • Loading branch information
turadg committed Jul 17, 2023
1 parent 3b351c2 commit b8e19f5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ module.exports = {
parser: '@typescript-eslint/parser',
parserOptions: lintTypes
? {
// this is not yet compatible with eslint lsp so it's conditioned on AGORIC_ESLINT_TYPES
EXPERIMENTAL_useProjectService: true,
sourceType: 'module',
project: [
'./packages/*/jsconfig.json',
Expand Down
6 changes: 3 additions & 3 deletions scripts/lint-with-types.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/bin/sh

# we don't collect type info by default because it can slow eslint by 8-10x
# FIXME even in CI it has become too slow so disable until https://github.com/Agoric/agoric-sdk/issues/5788
# export AGORIC_ESLINT_TYPES='keypresent'
# we don't collect type info by default because the EXPERIMENTAL_useProjectService that provides viable perf
# is not yet compatible with running eslint in IDE
export AGORIC_ESLINT_TYPES='keypresent'

# CI and some VMs OOM without this
export NODE_OPTIONS='--max-old-space-size=8192'
Expand Down

0 comments on commit b8e19f5

Please sign in to comment.