Skip to content

Commit

Permalink
checking the name of accessors to ensure it does not conflict with an…
Browse files Browse the repository at this point in the history
… existing page-object method name
  • Loading branch information
cheezy committed Jul 19, 2014
1 parent f5ba571 commit 2ac9a11
Show file tree
Hide file tree
Showing 8 changed files with 108 additions and 48 deletions.
2 changes: 1 addition & 1 deletion .rspec
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
--color
--format Fuubar
--format documentation
4 changes: 2 additions & 2 deletions features/step_definitions/element_steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ class HoverPage
class DoubleClickPage
include PageObject
button(:click)
paragraph(:text)
paragraph(:p_text)
end

Given /^I am on the Double Click page$/ do
Expand All @@ -233,7 +233,7 @@ class DoubleClickPage
end

Then /^the paragraph should read "([^\"]*)"$/ do |expected_text|
@page.text.should == expected_text
@page.p_text.should == expected_text
end

When /^I scroll the heading element into view$/ do
Expand Down
5 changes: 0 additions & 5 deletions features/support/page.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ class Page
text_area(:text_area_css, :css => ".text_area_class")
text_area(:text_area_name, :name => "text_area_name")
text_area(:text_area_xpath, :xpath => "//textarea")
text_area(:text_area_css, :css => "textarea")
text_area(:text_area_tag_name, :tag_name => "textarea")
text_area(:text_area_index, :index => 0)
text_area(:text_area_text, :text => "")
Expand All @@ -42,7 +41,6 @@ class Page
hidden_field(:hidden_field_css, :css => ".hidden_field_class")
hidden_field(:hidden_field_name, :name => "hidden_field_name")
hidden_field(:hidden_field_xpath, :xpath => "//input[@type='hidden']")
hidden_field(:hidden_field_css, :css => "input[type='hidden']")
hidden_field(:hidden_field_tag_name, :tag_name => "input[type='hidden']")
hidden_field(:hidden_field_index, :index => 0)
hidden_field(:hidden_field_text, :text => "")
Expand All @@ -60,7 +58,6 @@ class Page
link(:google_search_href, :href => "success.html")
link(:google_search_text, :text => "Google Search")
link(:google_search_index, :index => 0)
link(:google_search_css, :css => "a.link_class")
link(:google_search_title, :title => "link_title")

select_list(:sel_list_id, :id => "sel_list_id")
Expand Down Expand Up @@ -112,7 +109,6 @@ class Page
div(:div_title, :title => 'div_title')
div(:div_class_index, :class => "div_class", :index => 0)
div(:div_name_index, :name => "div_name", :index => 0)
div(:div_css, :css => ".div_class")

div(:div_data_entity, :data_entity => "test")

Expand Down Expand Up @@ -155,7 +151,6 @@ class Page
button(:button_xpath, :xpath=> "//input[@type='submit']")
button(:button_text, :text => 'Click Me')
button(:button_value, :value => 'Click Me')
button(:button_css, :css => "input[type='submit']")
button(:button_class_index, :class => "button_class", :index => 0)
button(:button_name_index, :name => "button_name", :index => 0)

Expand Down
Loading

0 comments on commit 2ac9a11

Please sign in to comment.