Remove hardcoded sizes.

mehrbodkh · Aug 9, 2021 · 0759acf · 0759acf
1 parent 67a401b
commit 0759acf
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 19 deletions.
diff --git a/app/src/main/res/layout/fragment_movie_detail.xml b/app/src/main/res/layout/fragment_movie_detail.xml
@@ -34,7 +34,7 @@
             <androidx.appcompat.widget.AppCompatImageView
                 android:id="@+id/photo"
                 android:layout_width="match_parent"
-                android:layout_height="180dp"
+                android:layout_height="@dimen/movie_detail_poster_height"
                 android:scaleType="centerCrop" />
 
             <androidx.appcompat.widget.AppCompatTextView
@@ -44,7 +44,7 @@
                 android:textAppearance="@style/TextAppearance.AppCompat.Title"
                 android:maxLines="2"
                 android:ellipsize="end"
-                android:layout_margin="16dp"/>
+                android:layout_margin="@dimen/margin_medium"/>
 
             <androidx.appcompat.widget.AppCompatTextView
                 android:id="@+id/genre"
@@ -53,8 +53,8 @@
                 android:textAppearance="@style/TextAppearance.AppCompat.Body2"
                 android:maxLines="1"
                 android:ellipsize="end"
-                android:layout_marginEnd="16dp"
-                android:layout_marginStart="16dp" />
+                android:layout_marginEnd="@dimen/margin_medium"
+                android:layout_marginStart="@dimen/margin_medium" />
 
             <androidx.appcompat.widget.AppCompatTextView
                 android:id="@+id/rating"
@@ -63,16 +63,16 @@
                 android:textAppearance="@style/TextAppearance.AppCompat.Body2"
                 android:maxLines="1"
                 android:ellipsize="end"
-                android:layout_marginEnd="16dp"
-                android:layout_marginStart="16dp" />
+                android:layout_marginEnd="@dimen/margin_medium"
+                android:layout_marginStart="@dimen/margin_medium" />
 
             <androidx.appcompat.widget.AppCompatTextView
                 android:id="@+id/info"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:textAppearance="@style/TextAppearance.AppCompat.Body2"
-                android:layout_marginEnd="16dp"
-                android:layout_marginStart="16dp" />
+                android:layout_marginEnd="@dimen/margin_medium"
+                android:layout_marginStart="@dimen/margin_medium" />
 
         </LinearLayout>
 

diff --git a/app/src/main/res/layout/item_movie.xml b/app/src/main/res/layout/item_movie.xml
@@ -8,9 +8,9 @@
         android:id="@+id/cover"
         android:layout_width="128dp"
         android:layout_height="160dp"
-        android:layout_marginStart="8dp"
-        android:layout_marginTop="8dp"
-        android:layout_marginBottom="8dp"
+        android:layout_marginStart="@dimen/margin_small_2x"
+        android:layout_marginTop="@dimen/margin_small_2x"
+        android:layout_marginBottom="@dimen/margin_small_2x"
         android:scaleType="centerCrop"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintStart_toStartOf="parent"
@@ -20,8 +20,8 @@
         android:id="@+id/title"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
-        android:layout_marginStart="16dp"
-        android:layout_marginEnd="8dp"
+        android:layout_marginStart="@dimen/margin_medium"
+        android:layout_marginEnd="@dimen/margin_small_2x"
         android:textAppearance="@style/TextAppearance.AppCompat.Title"
         app:layout_constraintStart_toEndOf="@id/cover"
         app:layout_constraintEnd_toEndOf="parent"
@@ -33,8 +33,8 @@
         android:id="@+id/genre"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginTop="8dp"
-        android:layout_marginEnd="8dp"
+        android:layout_marginTop="@dimen/margin_small_2x"
+        android:layout_marginEnd="@dimen/margin_small_2x"
         android:textAppearance="@style/TextAppearance.AppCompat.Body2"
         app:layout_constraintStart_toStartOf="@id/title"
         app:layout_constraintTop_toBottomOf="@id/title"/>

diff --git a/app/src/main/res/layout/movies_fragment.xml b/app/src/main/res/layout/movies_fragment.xml
@@ -11,7 +11,7 @@
         android:layout_width="match_parent"
         android:layout_height="0dp"
         android:layout_marginBottom="8dp"
-        android:padding="8dp"
+        android:padding="@dimen/margin_small_2x"
         android:clipToPadding="false"
         app:layout_constraintTop_toTopOf="parent"
         app:layout_constraintBottom_toTopOf="@id/temporaryButton"
@@ -33,9 +33,9 @@
         android:id="@+id/temporaryButton"
         android:layout_width="0dp"
         android:layout_height="56dp"
-        android:layout_marginStart="16dp"
-        android:layout_marginEnd="16dp"
-        android:layout_marginBottom="8dp"
+        android:layout_marginStart="@dimen/margin_medium"
+        android:layout_marginEnd="@dimen/margin_medium"
+        android:layout_marginBottom="@dimen/margin_small_2x"
         android:text="Temporary"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintBottom_toBottomOf="parent"

diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <!--    Margins    -->
+    <dimen name="margin_small_2x">8dp</dimen>
+    <dimen name="margin_small">12dp</dimen>
+    <dimen name="margin_medium">16dp</dimen>
+    <dimen name="margin_large">24dp</dimen>
+
+    <dimen name="movie_detail_poster_height">180dp</dimen>
+</resources>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+
+</resources>