Fixes local const shadowed by global const with same name. (FuelLabs#…

…3402)

With PR FuelLabs#3233 `compile_const_decl` is now able to check for local
variables. To fix the issue described in FuelLabs#3237 we need to pass the
`FnCompiler` to `compile_constant_expression` so it can check the local
variables in use.

Closes FuelLabs#3237

sway-core/src/ir_generation/function.rs

@@ -1481,7 +1481,7 @@ impl FnCompiler {
         // globals like other const decls.
         let ty::TyConstantDeclaration { name, value, .. } = ast_const_decl;
         let const_expr_val =
-            compile_constant_expression(context, md_mgr, self.module, None, None, &value)?;
+            compile_constant_expression(context, md_mgr, self.module, None, Some(self), &value)?;
         let local_name = self.lexical_map.insert(name.as_str().to_owned());
         let return_type = convert_resolved_typeid(context, &value.return_type, &value.span)?;
 

test/src/e2e_vm_tests/test_programs/should_pass/language/const_global_shadow/Forc.lock

@@ -0,0 +1,8 @@
+[[package]]
+name = 'const_global_shadow'
+source = 'member'
+dependencies = ['core']
+
+[[package]]
+name = 'core'
+source = 'path+from-root-37F288FECEE71F89'

test/src/e2e_vm_tests/test_programs/should_pass/language/const_global_shadow/Forc.toml

@@ -0,0 +1,8 @@
+[project]
+authors = ["Fuel Labs <[email protected]>"]
+license = "Apache-2.0"
+name = "const_global_shadow"
+entry = "main.sw"
+
+[dependencies]
+core = { path = "../../../../../../../sway-lib-core" }

test/src/e2e_vm_tests/test_programs/should_pass/language/const_global_shadow/json_abi_oracle.json

@@ -0,0 +1,22 @@
+{
+  "functions": [
+    {
+      "inputs": [],
+      "name": "main",
+      "output": {
+        "name": "",
+        "type": 0,
+        "typeArguments": null
+      }
+    }
+  ],
+  "loggedTypes": [],
+  "types": [
+    {
+      "components": null,
+      "type": "u64",
+      "typeId": 0,
+      "typeParameters": null
+    }
+  ]
+}

test/src/e2e_vm_tests/test_programs/should_pass/language/const_global_shadow/src/main.sw

@@ -0,0 +1,9 @@
+script;
+
+const GLOBAL_VAL: u64 = 1;
+
+fn main() -> u64 {
+    const GLOBAL_VAL = 100;
+    const LOCAL_VAL = GLOBAL_VAL;
+    LOCAL_VAL
+}

test/src/e2e_vm_tests/test_programs/should_pass/language/const_global_shadow/test.toml

@@ -0,0 +1,3 @@
+category = "run"
+expected_result = { action = "return", value = 100 }
+validate_abi = true