drivers: i2s: nrfx: fix incorrect direction check

I2S direction was not checked correctly in the i2s_nrfx_configure function. This patch also fixes coverity issue 238365. Signed-off-by: Gerard Marull-Paretas <[email protected]>
meklort · Aug 26, 2021 · 086cfb3 · 086cfb3
1 parent 437f7f9
commit 086cfb3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drivers/i2s/i2s_nrfx.c b/drivers/i2s/i2s_nrfx.c
@@ -399,11 +399,11 @@ static int i2s_nrfx_configure(const struct device *dev, enum i2s_dir dir,
 
 	if (i2s_cfg->frame_clk_freq == 0) { /* -> reset state */
 		purge_queue(dev, dir);
-		if (dir == I2S_DIR_TX || I2S_DIR_BOTH) {
+		if (dir == I2S_DIR_TX || dir == I2S_DIR_BOTH) {
 			drv_data->tx_configured = false;
 			memset(&drv_data->tx, 0, sizeof(drv_data->tx));
 		}
-		if (dir == I2S_DIR_RX || I2S_DIR_BOTH) {
+		if (dir == I2S_DIR_RX || dir == I2S_DIR_BOTH) {
 			drv_data->rx_configured = false;
 			memset(&drv_data->rx, 0, sizeof(drv_data->rx));
 		}