chore(alert): Fix test for Angular 1.2

- Since Angular 1.2 is now using the ng-hide class to hide the element, it needs to be added into the DOM for styles to be computed.
menssen · Jan 8, 2014 · b940b06 · b940b06
1 parent 7a4f06c
commit b940b06
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/karma.conf.js b/karma.conf.js
@@ -6,6 +6,7 @@ basePath = '.';
 files = [
   JASMINE,
   JASMINE_ADAPTER,
+  'test-helpers.js',
   'misc/test-lib/jquery-1.8.2.min.js',
   'misc/test-lib/angular.js',
   'misc/test-lib/angular-mocks.js',

diff --git a/src/alert/test/alert.spec.js b/src/alert/test/alert.spec.js
@@ -84,7 +84,7 @@ describe("alert", function () {
   it('should not show close buttons if no close callback specified', function () {
     element = $compile('<alert>No close</alert>')(scope);
     scope.$digest();
-    expect(findCloseButton(0).css('display')).toBe('none');
+    expect(findCloseButton(0)).toBeHidden();
   });
 
   it('should be possible to add additional classes for alert', function () {

diff --git a/test-helpers.js b/test-helpers.js
@@ -0,0 +1,9 @@
+beforeEach(function () {
+  this.addMatchers({
+    toBeHidden: function () {
+      var element = angular.element(this.actual);
+      return element.hasClass('ng-hide') ||
+        element.css('display') == 'none';
+    }
+  });
+});