Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

多方面优化 #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

多方面优化 #26

wants to merge 6 commits into from

Conversation

Sunbread
Copy link
Contributor

@Sunbread Sunbread commented Nov 1, 2019

  • 标点规范化
  • 去除莫名其妙的空格
  • 更标准的自然段格式（开头空格和结尾标点）
  • 避免空行
  • 修复重复生成主题字数次文章的bug
  • 一次读取多个文章主题输入
  • 重构部分代码
  • 可能还有更多（半夜提交记性不好）……

@Sunbread
多方面优化
091df87 
- 标点规范化
- 去除莫名其妙的空格
- 更标准的自然段格式（开头空格和结尾标点）
- 避免空行
- 修复重复生成主题字数次文章的bug
- 一次读取多个文章主题输入
- 重构部分代码
- 可能还有更多（半夜提交记性不好）……
@Sunbread
Copy link
Contributor Author

Sunbread commented Nov 2, 2019

@liyishuai 可以给一些建议吗？半夜写的，有些地方可能还是很不完善。

@abc1763613206
Copy link

tmp[-1]来判结尾是否有效？

我写的是如果末尾不是句号就持续拼接，但是看上去不太管用 🤔

https://github.com/abc1763613206/TGBullshitGeneratorBot/blob/master/main.py#L52-L67

@Sunbread
Copy link
Contributor Author

Sunbread commented Nov 2, 2019

tmp[-1]来判结尾是否有效？

我写的是如果末尾不是句号就持续拼接，但是看上去不太管用 thinking

https://github.com/abc1763613206/TGBullshitGeneratorBot/blob/master/main.py#L52-L67

请说清楚哪里出了问题，谢谢。

@Sunbread
Copy link
Contributor Author

Sunbread commented Nov 2, 2019

新增：

@Sunbread
Copy link
Contributor Author

Sunbread commented Nov 3, 2019

@menzi11 合并过程中遇到什么问题了吗？

@Sunbread
Copy link
Contributor Author

已合并上游提交。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-z-l p-z-l p-z-l left review comments

@callmedada callmedada callmedada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sunbread @abc1763613206 @callmedada @p-z-l