check stack len before getting value

meskill · Nov 22, 2019 · 5080040 · 5080040
1 parent 7bb570a
commit 5080040
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/lib/llvm-backend/src/state.rs b/lib/llvm-backend/src/state.rs
@@ -240,12 +240,16 @@ impl State {
         &self,
         n: usize,
     ) -> Result<&[(BasicValueEnum, ExtraInfo)], BinaryReaderError> {
-        self.stack
-            .get(self.stack.len() - n..)
-            .ok_or(BinaryReaderError {
+        if self.stack.len() < n {
+            return Err(BinaryReaderError {
                 message: "invalid value stack",
                 offset: -1isize as usize,
-            })
+            });
+        }
+
+        let new_len = self.stack.len() - n;
+        Ok(&self.stack[new_len..])
+
     }
 
     pub fn popn_save_extra(