Ask for confirmation before taking action in job summary #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2017 18:43
All other actions appear to be sending ``event`` instead of ``this``, I believe this works just as well (from my testing)
It is really important to ask for confirmation before deleting a job, I think. It is probably somewhat important to ask for confirmation before starting and stopping jobs, I think.
|
The travis failure seems unrelated to my change, as far as I can see? |
|
Seems this repo has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #816, putting a confirmation dialog before running/stopping/deleting jobs seems like a good idea. Not using any fancy react libraries just good ol' javascript.
I am not specially sure about 7cfe1f3 but it seems to work just fine, I believe it to be a typo because the function definition for
deleteJob()in ln181 expects an event.