Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): fix a cannot found cmake issue when install from source with venv'ed cmake #191

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

XuehaiPan
Copy link
Member

@XuehaiPan XuehaiPan commented Feb 17, 2025

Description

Describe your changes in detail.

Unset PYTHONPATH before calling cmake in subprocess.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

See the following issues for more context:

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan self-assigned this Feb 17, 2025
@XuehaiPan XuehaiPan added the bug Something isn't working label Feb 17, 2025
@XuehaiPan XuehaiPan changed the title fix(setup): fix a cannot found cmake issue when install from source with venv'ed cmake fix(setup): fix a cannot found cmake issue when install from source with venv'ed cmake Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (acf6ab3) to head (159710b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3987      3987           
=========================================
  Hits          3987      3987           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XuehaiPan XuehaiPan force-pushed the fix-build-from-source branch from fa02e5f to 8985606 Compare February 17, 2025 18:29
@XuehaiPan XuehaiPan force-pushed the fix-build-from-source branch from 8985606 to 9ef29bb Compare February 17, 2025 18:33
@XuehaiPan XuehaiPan force-pushed the fix-build-from-source branch from fe61ada to 3f4b598 Compare February 18, 2025 16:06
@XuehaiPan XuehaiPan force-pushed the fix-build-from-source branch from 159710b to d94208b Compare February 20, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant