Enable some fbgemm::pack_segments tests (pytorch#2082)

Summary: Pull Request resolved: pytorch#2082 See previous diff. Reviewed By: zou3519 Differential Revision: D50509467 fbshipit-source-id: 7b4aab969ad4736e203c114cd13f379d05284501
meteorfox · Oct 24, 2023 · 688ad65 · 688ad65
1 parent f94254d
commit 688ad65
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 27 deletions.
diff --git a/fbgemm_gpu/test/failures_dict.json b/fbgemm_gpu/test/failures_dict.json
@@ -491,7 +491,16 @@
         "status": "xfail"
       }
     },
-    "fbgemm::pack_segments": {},
+    "fbgemm::pack_segments": {
+      "SparseOpsTest.test_aot_dispatch_dynamic__test_pack_segments": {
+        "comment": "",
+        "status": "xfail"
+      },
+      "SparseOpsTest.test_aot_dispatch_static__test_pack_segments": {
+        "comment": "",
+        "status": "xfail"
+      }
+    },
     "fbgemm::permute102_baddbmm_permute102": {
       "SparseOpsTest.test_aot_dispatch_dynamic__test_permute102_baddbmm_permute102": {
         "comment": "",

diff --git a/fbgemm_gpu/test/sparse_ops_test.py b/fbgemm_gpu/test/sparse_ops_test.py
@@ -2415,38 +2415,12 @@ def validate(
     "test_faketensor__test_index_select_dim0": [unittest.skip("hangs")],
     "test_autograd_registration__test_index_select_dim0": [unittest.skip("hangs")],
     "test_schema__test_index_select_dim0": [unittest.skip("hangs")],
-    "test_aot_dispatch_dynamic__test_pack_segments": [
-        unittest.skip("ASAN heap buffer overflow")
-    ],
-    "test_aot_dispatch_static__test_pack_segments": [
-        unittest.skip("ASAN heap buffer overflow")
-    ],
-    "test_faketensor__test_pack_segments": [unittest.skip("ASAN heap buffer overflow")],
-    "test_autograd_registration__test_pack_segments": [
-        unittest.skip("ASAN heap buffer overflow")
-    ],
-    "test_schema__test_pack_segments": [unittest.skip("ASAN heap buffer overflow")],
     "test_aot_dispatch_static__test_group_index_select_dim0": [
         unittest.skip("CUDA memory error")
     ],
     "test_aot_dispatch_dynamic__test_group_index_select_dim0": [
         unittest.skip("CUDA memory error")
     ],
-    "test_aot_dispatch_dynamic__test_pack_segments_smaller_max_len": [
-        unittest.skip("RuntimeError: opcheck can only test operators without overloads")
-    ],
-    "test_aot_dispatch_static__test_pack_segments_smaller_max_len": [
-        unittest.skip("RuntimeError: opcheck can only test operators without overloads")
-    ],
-    "test_faketensor__test_pack_segments_smaller_max_len": [
-        unittest.skip("RuntimeError: opcheck can only test operators without overloads")
-    ],
-    "test_autograd_registration__test_pack_segments_smaller_max_len": [
-        unittest.skip("RuntimeError: opcheck can only test operators without overloads")
-    ],
-    "test_schema__test_pack_segments_smaller_max_len": [
-        unittest.skip("RuntimeError: opcheck can only test operators without overloads")
-    ],
 }
 
 # only generate tests on nightly pytorch (current release version is 2.1)