Skip to content

Commit

Permalink
upstream: note successful authentication method in final "Authenticated
Browse files Browse the repository at this point in the history
to ..." message and partial auth success messages (all at LogLevel=verbose)
ok dtucker@

OpenBSD-Commit-ID: 06834b89ceb89f8f16c5321d368a66c08f441984
  • Loading branch information
djmdjm committed Jul 23, 2021
1 parent a917e97 commit 9e1882e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
9 changes: 1 addition & 8 deletions ssh.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* $OpenBSD: ssh.c,v 1.564 2021/07/23 04:04:52 djm Exp $ */
/* $OpenBSD: ssh.c,v 1.565 2021/07/23 05:24:02 djm Exp $ */
/*
* Author: Tatu Ylonen <[email protected]>
* Copyright (c) 1995 Tatu Ylonen <[email protected]>, Espoo, Finland
Expand Down Expand Up @@ -1651,13 +1651,6 @@ main(int ac, char **av)
ssh_login(ssh, &sensitive_data, host, (struct sockaddr *)&hostaddr,
options.port, pw, timeout_ms, cinfo);

if (ssh_packet_connection_is_on_socket(ssh)) {
verbose("Authenticated to %s ([%s]:%d).", host,
ssh_remote_ipaddr(ssh), ssh_remote_port(ssh));
} else {
verbose("Authenticated to %s (via proxy).", host);
}

/* We no longer need the private host keys. Clear them now. */
if (sensitive_data.nkeys != 0) {
for (i = 0; i < sensitive_data.nkeys; i++) {
Expand Down
14 changes: 11 additions & 3 deletions sshconnect2.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* $OpenBSD: sshconnect2.c,v 1.350 2021/07/02 05:11:21 dtucker Exp $ */
/* $OpenBSD: sshconnect2.c,v 1.351 2021/07/23 05:24:02 djm Exp $ */
/*
* Copyright (c) 2000 Markus Friedl. All rights reserved.
* Copyright (c) 2008 Damien Miller. All rights reserved.
Expand Down Expand Up @@ -487,7 +487,14 @@ ssh_userauth2(struct ssh *ssh, const char *local_user,

if (!authctxt.success)
fatal("Authentication failed.");
debug("Authentication succeeded (%s).", authctxt.method->name);
if (ssh_packet_connection_is_on_socket(ssh)) {
verbose("Authenticated to %s ([%s]:%d) using \"%s\".", host,
ssh_remote_ipaddr(ssh), ssh_remote_port(ssh),
authctxt.method->name);
} else {
verbose("Authenticated to %s (via proxy) using \"%s\".", host,
authctxt.method->name);
}
}

/* ARGSUSED */
Expand Down Expand Up @@ -645,7 +652,8 @@ input_userauth_failure(int type, u_int32_t seq, struct ssh *ssh)
goto out;

if (partial != 0) {
verbose("Authenticated with partial success.");
verbose("Authenticated using \"%s\" with partial success.",
authctxt->method->name);
/* reset state */
pubkey_reset(authctxt);
}
Expand Down

0 comments on commit 9e1882e

Please sign in to comment.