lints

core/bin/zksync_api/src/api_server/rpc_server/mod.rs

@@ -1,7 +1,6 @@
 // Built-in uses
 use std::{
     collections::{HashMap, HashSet},
-    convert::TryFrom,
     time::Instant,
 };
 
@@ -139,8 +138,8 @@ fn get_call_with_ip_if_needed(
 
     let description = methods_with_ip.get(&call.method);
 
-    let description = if description.is_some() {
-        description.unwrap()
+    let description = if let Some(description) = description {
+        description
     } else {
         return call;
     };

core/bin/zksync_api/src/api_server/tx_sender.rs

@@ -25,7 +25,6 @@ use zksync_api_types::{
     v02::transaction::{SubmitBatchResponse, Toggle2FA, Toggle2FAResponse, TxHashSerializeWrapper},
     TxWithSignature,
 };
-use zksync_config::ZkSyncConfig;
 use zksync_storage::misc::records::Subsidy;
 use zksync_storage::{chain::account::records::EthAccountType, ConnectionPool};
 use zksync_types::{

core/bin/zksync_api/src/fee_ticker/tests.rs

@@ -284,7 +284,7 @@ fn get_normal_and_subsidy_fee(
         .expect("failed to get fee in token");
 
     let batched_fee_in_token =
-        block_on(ticker.get_batch_from_ticker_in_wei(token.clone(), vec![(tx_type, address)]))
+        block_on(ticker.get_batch_from_ticker_in_wei(token, vec![(tx_type, address)]))
             .expect("failed to get batched fee for token");
 
     assert_eq!(
@@ -484,9 +484,8 @@ fn test_ticker_subsidy() {
 
     // The subsidy price is more-or-less same in all tokens
     let mut scaled_prices: Vec<i64> = vec![];
-    let tokens: Vec<_> = TestToken::all_tokens().into_iter().take(3).collect();
 
-    for token in tokens.clone().into_iter() {
+    for token in TestToken::all_tokens().into_iter().take(3) {
         let price_usd = get_subsidy_token_fee_in_usd(
             &mut ticker,
             cpk(ChangePubKeyType::CREATE2),

core/lib/storage/src/misc/mod.rs

@@ -1,24 +1,11 @@
 // Built-in deps
-use std::collections::{HashMap, HashSet};
 use std::time::Instant;
 // External imports
-use num::{rational::Ratio, BigUint};
-
 use sqlx::types::BigDecimal;
-use thiserror::Error;
-// Workspace imports
-use zksync_api_types::v02::{
-    pagination::{PaginationDirection, PaginationQuery},
-    token::ApiNFT,
-};
-use zksync_types::{AccountId, Address, Token, TokenId, TokenLike, TokenPrice, NFT};
-use zksync_utils::ratio_to_big_decimal;
 // Local imports
 
 use self::records::Subsidy;
-use crate::utils::address_to_stored_string;
 use crate::{QueryResult, StorageProcessor};
-use zksync_types::tokens::TokenMarketVolume;
 
 pub mod records;
 
@@ -68,7 +55,7 @@ impl<'a, 'c> MiscSchema<'a, 'c> {
         .fetch_one(self.0.conn())
         .await?
         .total
-        .unwrap_or(BigDecimal::from(0));
+        .unwrap_or_else(|| BigDecimal::from(0));
 
         metrics::histogram!("sql.token.load_tokens_asc", start.elapsed());
         Ok(sum)

core/lib/storage/src/tests/misc.rs

@@ -4,7 +4,6 @@ use zksync_types::TokenId;
 use crate::tests::db_test;
 use crate::{misc::records::Subsidy, misc::MiscSchema};
 use crate::{QueryResult, StorageProcessor};
-use std::time::SystemTime;
 
 fn get_subsidy(name: String, value: u64) -> Subsidy {
     // The only fields that matter are `subsidy_type` and `value`

core/tests/ts-tests/tests/suits/subsidy.ts

@@ -1,6 +1,6 @@
-import { expect, use } from 'chai';
-import { BigNumber, utils } from 'ethers';
-import { Wallet, types } from 'zksync';
+import { use } from 'chai';
+import { utils } from 'ethers';
+import { Wallet } from 'zksync';
 import chaiAsPromised from 'chai-as-promised';
 import { Tester } from '../tester/tester';
 import '../tester/priority-ops';
@@ -38,25 +38,10 @@ describe.only(`Subsidy tests`, () => {
 
     let tester: Tester;
     let alice: Wallet;
-    let bob: Wallet;
-    let chuck: Wallet;
-    let david: Wallet;
-    let frank: Wallet;
-    let judy: Wallet;
-    let chris: Wallet;
-    let operatorBalance: BigNumber;
-    let nft: types.NFT;
 
     before('create tester and test wallets', async () => {
         tester = await Tester.init('localhost', transport, providerType);
         alice = await tester.fundedWallet('5.0');
-        bob = await tester.emptyWallet();
-        chuck = await tester.emptyWallet();
-        david = await tester.fundedWallet('1.0');
-        frank = await tester.fundedWallet('1.0');
-        judy = await tester.emptyWallet();
-        chris = await tester.emptyWallet();
-        operatorBalance = await tester.operatorBalance(token);
     });
 
     after('disconnect tester', async () => {

core/tests/ts-tests/tests/tester/misc.ts

@@ -1,4 +1,4 @@
-import { expectThrow, Tester } from './tester';
+import { Tester } from './tester';
 import { expect } from 'chai';
 import { Wallet, types, Create2WalletSigner } from 'zksync';
 import { BigNumber, ethers } from 'ethers';