forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ack response implement (apache#8161)
## Motivation Now acknowledge messages will not get response, but acknowledge messages with transaction will check the acknowledge whether conflict with other transaction in pendingack. We can commit or abort the transaction after we get the response. ## Modification - We add requestId field in ack protocol and it type is optional. - Server handle the ack command, if the command carry the requestId, server will return the response. - In normal, we don't need to get response. Unless we ack with transaction. ## Compatibility This PR is for transaction, and don't change any client api, so we don't need to think about the compatibility question.
- Loading branch information
1 parent
757cd5a
commit 59e0cfb
Showing
21 changed files
with
518 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ConsumerAckResponseTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.client.impl; | ||
|
|
||
| import lombok.Cleanup; | ||
|
|
||
| import org.apache.pulsar.client.api.Message; | ||
| import org.apache.pulsar.client.api.Producer; | ||
| import org.apache.pulsar.client.api.ProducerConsumerBase; | ||
| import org.apache.pulsar.client.api.PulsarClientException; | ||
| import org.apache.pulsar.client.api.Schema; | ||
| import org.apache.pulsar.client.api.SubscriptionType; | ||
| import org.apache.pulsar.client.impl.transaction.TransactionImpl; | ||
|
|
||
| import org.testng.Assert; | ||
| import org.testng.annotations.AfterClass; | ||
| import org.testng.annotations.BeforeClass; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.ExecutionException; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import static org.junit.Assert.fail; | ||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.doNothing; | ||
| import static org.mockito.Mockito.doReturn; | ||
| import static org.mockito.Mockito.mock; | ||
|
|
||
|
|
||
| public class ConsumerAckResponseTest extends ProducerConsumerBase { | ||
|
|
||
| private final static TransactionImpl transaction = mock(TransactionImpl.class); | ||
|
|
||
| @BeforeClass | ||
| public void setup() throws Exception { | ||
| super.internalSetup(); | ||
| super.producerBaseSetup(); | ||
| doReturn(1L).when(transaction).getTxnIdLeastBits(); | ||
| doReturn(1L).when(transaction).getTxnIdMostBits(); | ||
| CompletableFuture<Void> completableFuture = new CompletableFuture<>(); | ||
| doReturn(completableFuture).when(transaction).registerAckOp(any()); | ||
| doNothing().when(transaction).registerAckedTopic(any(), any()); | ||
|
|
||
| Thread.sleep(1000 * 3); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public void cleanup() throws Exception { | ||
| super.internalCleanup(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testAckResponse() throws PulsarClientException, InterruptedException, ExecutionException { | ||
| String topic = "testAckResponse"; | ||
| @Cleanup | ||
| Producer<Integer> producer = pulsarClient.newProducer(Schema.INT32) | ||
| .topic(topic) | ||
| .enableBatching(false) | ||
| .create(); | ||
| @Cleanup | ||
| ConsumerImpl<Integer> consumer = (ConsumerImpl<Integer>) pulsarClient.newConsumer(Schema.INT32) | ||
| .topic(topic) | ||
| .subscriptionName("sub") | ||
| .subscriptionType(SubscriptionType.Shared) | ||
| .ackTimeout(1, TimeUnit.SECONDS) | ||
| .subscribe(); | ||
| producer.send(1); | ||
| producer.send(2); | ||
| try { | ||
| consumer.acknowledgeAsync(new MessageIdImpl(1, 1, 1), transaction).get(); | ||
| fail(); | ||
| } catch (ExecutionException e) { | ||
| Assert.assertTrue(e.getCause() instanceof PulsarClientException.TransactionConflictException); | ||
| } | ||
| Message<Integer> message = consumer.receive(); | ||
| consumer.acknowledgeAsync(message.getMessageId(), transaction).get(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.