MDL-66200 gradebook: check selected feedback option when importing data

mgleeson · Apr 9, 2020 · c74ccbc · c74ccbc
1 parent df0e58a
commit c74ccbc
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/grade/import/lib.php b/grade/import/lib.php
@@ -112,7 +112,7 @@ function grade_import_commit($courseid, $importcode, $importfeedback=true, $verb
 
                 // make the grades array for update_grade
                 foreach ($grades as $grade) {
-                    if (!$importfeedback) {
+                    if (!$importfeedback || $grade->feedback === null) {
                         $grade->feedback = false; // ignore it
                     }
                     if ($grade->importonlyfeedback) {