Skip to content

Commit

Permalink
mm: use non-racy method for /proc/swaps creation
Browse files Browse the repository at this point in the history
Use proc_create() to make sure that ->proc_fops be setup before gluing PDE to
main tree.

Signed-off-by: Denis V. Lunev <[email protected]>
Cc: Alexey Dobriyan <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
dlunev authored and torvalds committed Apr 29, 2008
1 parent 6a6375d commit 3d71f86
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions mm/swapfile.c
Original file line number Diff line number Diff line change
Expand Up @@ -1426,11 +1426,7 @@ static const struct file_operations proc_swaps_operations = {

static int __init procswaps_init(void)
{
struct proc_dir_entry *entry;

entry = create_proc_entry("swaps", 0, NULL);
if (entry)
entry->proc_fops = &proc_swaps_operations;
proc_create("swaps", 0, NULL, &proc_swaps_operations);
return 0;
}
__initcall(procswaps_init);
Expand Down

0 comments on commit 3d71f86

Please sign in to comment.