Skip to content

Commit

Permalink
perf ui hist browser: Fixup key bindings
Browse files Browse the repository at this point in the history
To match what is shown when '?' or 'H' is pressed, i.e. the keybind help
window.

Cc: Frederic Weisbecker <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
acmel committed Aug 10, 2010
1 parent 59e8fe3 commit 4694153
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions tools/perf/util/ui/browsers/hists.c
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,12 @@ static int hist_browser__run(struct hist_browser *self, const char *title,
"Press '?' for help on key bindings") < 0)
return -1;

newtFormAddHotKey(self->b.form, 'A');
newtFormAddHotKey(self->b.form, 'a');
newtFormAddHotKey(self->b.form, '?');
newtFormAddHotKey(self->b.form, 'h');
newtFormAddHotKey(self->b.form, 'H');
newtFormAddHotKey(self->b.form, 'd');
newtFormAddHotKey(self->b.form, 'D');
newtFormAddHotKey(self->b.form, 't');

newtFormAddHotKey(self->b.form, NEWT_KEY_LEFT);
newtFormAddHotKey(self->b.form, NEWT_KEY_RIGHT);
Expand All @@ -232,7 +232,7 @@ static int hist_browser__run(struct hist_browser *self, const char *title,
if (es->reason != NEWT_EXIT_HOTKEY)
break;
switch (es->u.key) {
case 'd': { /* Debug */
case 'D': { /* Debug */
static int seq;
struct hist_entry *h = rb_entry(self->b.top,
struct hist_entry, rb_node);
Expand Down Expand Up @@ -771,18 +771,17 @@ int hists__browse(struct hists *self, const char *helpline, const char *ev_name)
default:;
}

key = toupper(key);
switch (key) {
case 'A':
case 'a':
if (browser->selection->map == NULL &&
browser->selection->map->dso->annotate_warned)
continue;
goto do_annotate;
case 'D':
case 'd':
goto zoom_dso;
case 'T':
case 't':
goto zoom_thread;
case 'H':
case 'h':
case '?':
do_help:
ui__help_window("-> Zoom into DSO/Threads & Annotate current symbol\n"
Expand Down

0 comments on commit 4694153

Please sign in to comment.