Skip to content

Commit

Permalink
fsl_usb2_udc: Add a wmb before priming endpoint.
Browse files Browse the repository at this point in the history
Add a wmb to fsl_queue_td before priming the endpoint. This ensures that the
modifications to the QH are seen by the hardware.

Added comment as suggested by Felipe Balbi.

Signed-off-by: Will Newton <[email protected]>
Acked-by: Li Yang <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
willnewton authored and gregkh committed Oct 17, 2008
1 parent 224b503 commit 59097fb
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/usb/gadget/fsl_usb2_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@ static void fsl_queue_td(struct fsl_ep *ep, struct fsl_req *req)
| EP_QUEUE_HEAD_STATUS_HALT));
dQH->size_ioc_int_sts &= temp;

/* Ensure that updates to the QH will occure before priming. */
wmb();

/* Prime endpoint by writing 1 to ENDPTPRIME */
temp = ep_is_in(ep)
? (1 << (ep_index(ep) + 16))
Expand Down

0 comments on commit 59097fb

Please sign in to comment.