Skip to content

Commit

Permalink
tpm: Fix compilation warning when CONFIG_PNP is not defined
Browse files Browse the repository at this point in the history
The is_itpm() function is only accessed from a block surrounded by
#ifdef CONFIG_PNP. Therefore, also surround it with #ifdef CONFIG_PNP
and remove the #else branch causing the warning.

http://lxr.linux.no/#linux+v2.6.39/drivers/char/tpm/tpm_tis.c#L622

v2:
 - fixes a previous typo

Signed-off-by: Stefan Berger <[email protected]>
Reported-by: Randy Dunlap <[email protected]>
Signed-off-by: James Morris <[email protected]>
  • Loading branch information
stefanberger authored and James Morris committed Jul 20, 2011
1 parent 0f2a55d commit 6eb77b2
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/char/tpm/tpm_tis.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ enum tis_defaults {
static LIST_HEAD(tis_chips);
static DEFINE_SPINLOCK(tis_lock);

#ifdef CONFIG_ACPI
#ifdef CONFIG_PNP
static int is_itpm(struct pnp_dev *dev)
{
struct acpi_device *acpi = pnp_acpi_device(dev);
Expand All @@ -93,11 +93,6 @@ static int is_itpm(struct pnp_dev *dev)

return 0;
}
#else
static int is_itpm(struct pnp_dev *dev)
{
return 0;
}
#endif

static int check_locality(struct tpm_chip *chip, int l)
Expand Down

0 comments on commit 6eb77b2

Please sign in to comment.