Skip to content

Commit

Permalink
Merge branches 'release', 'bugzilla-11880', 'bugzilla-12037' and 'bug…
Browse files Browse the repository at this point in the history
…zilla-12257' into release
  • Loading branch information
lenb committed Jan 9, 2009
4 parents a8e896e + 3e54048 + 935e5f2 + 7b37b5f commit b8ef914
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 21 deletions.
11 changes: 11 additions & 0 deletions arch/x86/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -1359,6 +1359,17 @@ static void __init acpi_process_madt(void)
"Invalid BIOS MADT, disabling ACPI\n");
disable_acpi();
}
} else {
/*
* ACPI found no MADT, and so ACPI wants UP PIC mode.
* In the event an MPS table was found, forget it.
* Boot with "acpi=off" to use MPS on such a system.
*/
if (smp_found_config) {
printk(KERN_WARNING PREFIX
"No APIC-table, disabling MPS\n");
smp_found_config = 0;
}
}
#endif
return;
Expand Down
43 changes: 22 additions & 21 deletions drivers/acpi/ec.c
Original file line number Diff line number Diff line change
Expand Up @@ -982,9 +982,9 @@ static const struct acpi_device_id ec_device_ids[] = {

int __init acpi_ec_ecdt_probe(void)
{
int ret;
acpi_status status;
struct acpi_table_ecdt *ecdt_ptr;
acpi_handle dummy;

boot_ec = make_acpi_ec();
if (!boot_ec)
Expand All @@ -1010,30 +1010,31 @@ int __init acpi_ec_ecdt_probe(void)
boot_ec->gpe = ecdt_ptr->gpe;
boot_ec->handle = ACPI_ROOT_OBJECT;
acpi_get_handle(ACPI_ROOT_OBJECT, ecdt_ptr->id, &boot_ec->handle);
} else {
/* This workaround is needed only on some broken machines,
* which require early EC, but fail to provide ECDT */
acpi_handle x;
printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
boot_ec, NULL);
/* Check that acpi_get_devices actually find something */
if (ACPI_FAILURE(status) || !boot_ec->handle)
goto error;
/* We really need to limit this workaround, the only ASUS,
* which needs it, has fake EC._INI method, so use it as flag.
* Keep boot_ec struct as it will be needed soon.
*/
if (ACPI_FAILURE(acpi_get_handle(boot_ec->handle, "_INI", &x)))
return -ENODEV;
/* Add some basic check against completely broken table */
if (boot_ec->data_addr != boot_ec->command_addr)
goto install;
/* fall through */
}

ret = ec_install_handlers(boot_ec);
if (!ret) {
/* This workaround is needed only on some broken machines,
* which require early EC, but fail to provide ECDT */
printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
boot_ec, NULL);
/* Check that acpi_get_devices actually find something */
if (ACPI_FAILURE(status) || !boot_ec->handle)
goto error;
/* We really need to limit this workaround, the only ASUS,
* which needs it, has fake EC._INI method, so use it as flag.
* Keep boot_ec struct as it will be needed soon.
*/
if (ACPI_FAILURE(acpi_get_handle(boot_ec->handle, "_INI", &dummy)))
return -ENODEV;
install:
if (!ec_install_handlers(boot_ec)) {
first_ec = boot_ec;
return 0;
}
error:
error:
kfree(boot_ec);
boot_ec = NULL;
return -ENODEV;
Expand Down
15 changes: 15 additions & 0 deletions drivers/acpi/video.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include <linux/backlight.h>
#include <linux/thermal.h>
#include <linux/video_output.h>
#include <linux/sort.h>
#include <asm/uaccess.h>

#include <acpi/acpi_bus.h>
Expand Down Expand Up @@ -625,6 +626,16 @@ acpi_video_bus_DOS(struct acpi_video_bus *video, int bios_flag, int lcd_flag)
return status;
}

/*
* Simple comparison function used to sort backlight levels.
*/

static int
acpi_video_cmp_level(const void *a, const void *b)
{
return *(int *)a - *(int *)b;
}

/*
* Arg:
* device : video output device (LCD, CRT, ..)
Expand Down Expand Up @@ -676,6 +687,10 @@ acpi_video_init_brightness(struct acpi_video_device *device)
count++;
}

/* don't sort the first two brightness levels */
sort(&br->levels[2], count - 2, sizeof(br->levels[2]),
acpi_video_cmp_level, NULL);

if (count < 2)
goto out_free_levels;

Expand Down

0 comments on commit b8ef914

Please sign in to comment.