VMware: Handle exception gracefully (ansible#36619)

This fix adds logic to handle exception raised from conversion of user parameter 'memory_mb'. Signed-off-by: Abhijeet Kasurde <[email protected]>
mgu · Mar 21, 2018 · aadbb6c · aadbb6c
1 parent 7a4c3e5
commit aadbb6c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/ansible/modules/cloud/vmware/vmware_guest.py b/lib/ansible/modules/cloud/vmware/vmware_guest.py
@@ -786,7 +786,12 @@ def configure_cpu_and_memory(self, vm_obj, vm_creation=False):
                 self.module.fail_json(msg="hardware.num_cpus attribute is mandatory for VM creation")
 
             if 'memory_mb' in self.params['hardware']:
-                self.configspec.memoryMB = int(self.params['hardware']['memory_mb'])
+                try:
+                    self.configspec.memoryMB = int(self.params['hardware']['memory_mb'])
+                except ValueError:
+                    self.module.fail_json(msg="Failed to parse hardware.memory_mb value."
+                                              " Please refer the documentation and provide"
+                                              " correct value.")
                 if vm_obj is None or self.configspec.memoryMB != vm_obj.config.hardware.memoryMB:
                     self.change_detected = True
             # memory_mb is mandatory for VM creation