Fix: Adding check for alias suffix and tests

mholleville · Mar 28, 2020 · 106a162 · 106a162
1 parent 0038bb1
commit 106a162
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/kcli/app.go b/kcli/app.go
@@ -39,7 +39,11 @@ func GenerateAlias(module string) string {
 	}
 	splittedModule := strings.SplitN(module, "-", 2)
 	if val, ok := aliasMap[splittedModule[0]]; ok {
-		return val + splittedModule[1]
+		suffix := ""
+		if len(splittedModule) > 1 {
+			suffix = splittedModule[1]
+		}
+		return val + suffix
 	} else {
 		return module
 	}

diff --git a/kcli/test/app_test.go b/kcli/test/app_test.go
@@ -6,16 +6,26 @@ import (
 )
 
 // GenerateAlias(module string) string //
-func TestTFAlias(t *testing.T){
+func TestTFProjectAlias(t *testing.T){
 	result := kcli.GenerateAlias("terraform-project")
 	equals(t, "tfproject", result)
 }
 
-func TestASAlias(t *testing.T){
+func TestTFAlias(t *testing.T){
+	result := kcli.GenerateAlias("terraform")
+	equals(t, "tf", result)
+}
+
+func TestASRoleAlias(t *testing.T){
 	result := kcli.GenerateAlias("ansible-role")
 	equals(t, "asrole", result)
 }
 
+func TestASAlias(t *testing.T){
+	result := kcli.GenerateAlias("ansible")
+	equals(t, "as", result)
+}
+
 func TestHelmAlias(t *testing.T){
 	result := kcli.GenerateAlias("helm")
 	equals(t, "helm", result)