Skip to content

Commit

Permalink
Remove min/max Width/Height in the docs
Browse files Browse the repository at this point in the history
Summary:
An initial implementation was done on css-layout but isn't working correctly on many cases. The binding from React Native has been removed a long time ago. Let's not confuse people and remove it from the docs :)
Closes facebook#5522

Reviewed By: svcscm

Differential Revision: D2859665

Pulled By: vjeux

fb-gh-sync-id: 4aa008dd93a6cea6b79a7bce444c94148791eee4
  • Loading branch information
vjeux authored and facebook-github-bot-7 committed Jan 28, 2016
1 parent af2f407 commit 2529179
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 16 deletions.
4 changes: 0 additions & 4 deletions Libraries/StyleSheet/LayoutPropTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@ var ReactPropTypes = require('ReactPropTypes');
*/
var LayoutPropTypes = {
width: ReactPropTypes.number,
maxWidth: ReactPropTypes.number,
minWidth: ReactPropTypes.number,
height: ReactPropTypes.number,
maxHeight: ReactPropTypes.number,
minHeight: ReactPropTypes.number,
top: ReactPropTypes.number,
left: ReactPropTypes.number,
right: ReactPropTypes.number,
Expand Down
4 changes: 0 additions & 4 deletions React/Views/RCTShadowView.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, UIView *> *viewRegistry

@property (nonatomic, assign) CGFloat width;
@property (nonatomic, assign) CGFloat height;
@property (nonatomic, assign) CGFloat minWidth;
@property (nonatomic, assign) CGFloat minHeight;
@property (nonatomic, assign) CGFloat maxWidth;
@property (nonatomic, assign) CGFloat maxHeight;
@property (nonatomic, assign) CGRect frame;

- (void)setTopLeft:(CGPoint)topLeft;
Expand Down
4 changes: 0 additions & 4 deletions React/Views/RCTShadowView.m
Original file line number Diff line number Diff line change
Expand Up @@ -507,10 +507,6 @@ - (CGFloat)getProp \

RCT_DIMENSIONS_PROPERTY(Width, width, WIDTH, dimensions)
RCT_DIMENSIONS_PROPERTY(Height, height, HEIGHT, dimensions)
RCT_DIMENSIONS_PROPERTY(MinWidth, minWidth, WIDTH, minDimensions)
RCT_DIMENSIONS_PROPERTY(MinHeight, minHeight, HEIGHT, minDimensions)
RCT_DIMENSIONS_PROPERTY(MaxWidth, maxWidth, WIDTH, maxDimensions)
RCT_DIMENSIONS_PROPERTY(MaxHeight, maxHeight, HEIGHT, maxDimensions)

// Position

Expand Down
4 changes: 0 additions & 4 deletions React/Views/RCTViewManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,6 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowViewRegistry:(__unused NSDictio

RCT_EXPORT_SHADOW_PROPERTY(width, CGFloat)
RCT_EXPORT_SHADOW_PROPERTY(height, CGFloat)
RCT_EXPORT_SHADOW_PROPERTY(minWidth, CGFloat)
RCT_EXPORT_SHADOW_PROPERTY(minHeight, CGFloat)
RCT_EXPORT_SHADOW_PROPERTY(maxWidth, CGFloat)
RCT_EXPORT_SHADOW_PROPERTY(maxHeight, CGFloat)

RCT_EXPORT_SHADOW_PROPERTY(borderTopWidth, CGFloat)
RCT_EXPORT_SHADOW_PROPERTY(borderRightWidth, CGFloat)
Expand Down

0 comments on commit 2529179

Please sign in to comment.