Skip to content

Commit

Permalink
[Interpreter] Updates InlineTwice in test-run-inlining to match other…
Browse files Browse the repository at this point in the history
… tests.

Updates InlineTwice to declare a function and then return a function
instead of using function expressions by wrapping a function with '('
and ')'. The earlier implementation would cause the function to
compile immediately instead of lazy compile. Also updates cctest.status

BUG=v8:4280,v8:4837,v8:4680
LOG=N

Review URL: https://codereview.chromium.org/1800073002

Cr-Commit-Position: refs/heads/master@{#34790}
  • Loading branch information
mythrialle authored and Commit bot committed Mar 15, 2016
1 parent 6b50388 commit c838363
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 0 additions & 4 deletions test/cctest/cctest.status
Original file line number Diff line number Diff line change
Expand Up @@ -549,10 +549,6 @@

# TODO(mythria,4680): Incorrect column number on eval.
'test-api/PromiseRejectCallback': [FAIL],

# TODO(rmcilroy,4680): Test assert errors.
'test-run-inlining/InlineTwice': [FAIL],

}], # ignition == True

['ignition == True and msan', {
Expand Down
3 changes: 2 additions & 1 deletion test/cctest/compiler/test-run-inlining.cc
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ TEST(InlineTwice) {
"(function () {"
" var x = 42;"
" function bar(s) { AssertInlineCount(2); return x + s; };"
" return (function (s,t) { return bar(s) + bar(t); });"
" function foo(s, t) { return bar(s) + bar(t); };"
" return foo;"
"})();",
kInlineFlags);

Expand Down

0 comments on commit c838363

Please sign in to comment.