-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to fmt 10.1.1, fast_double_parser 0.7.0 #6074
Conversation
CMAKE_CXX_FLAGS | ||
"${CMAKE_CXX_FLAGS} -Wno-stringop-overflow" | ||
) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used to suppress the following warning that shows up only with MinGW (gcc 10):
[ 60%] Building CXX object CMakeFiles/lightgbm_objs.dir/src/network/linkers_mpi.cpp.obj
d:\a\lightgbm\lightgbm\lightgbm.rcheck\00_pkg_src\lightgbm\src\external_libs\fmt\include\fmt\format.h: In function 'void fmt::v10::detail::format_hexfloat(Float, int, fmt::v10::detail::float_specs, fmt::v10::detail::buffer<char>&) [with Float = double; typename std::enable_if<(! std::integral_constant<bool, (std::numeric_limits<_Tp>::digits == 106)>::value), int>::type <anonymous> = 0]':
d:\a\lightgbm\lightgbm\lightgbm.rcheck\00_pkg_src\lightgbm\src\external_libs\fmt\include\fmt\format.h:1370:8: note: at offset -2 to object 'buffer' with size 10 declared here
1370 | Char buffer[digits10<UInt>() + 1] = {};
| ^~~~~~
Per fmtlib/fmt#1810 (comment), this was a false positive and a bug in gcc
10 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95353). Seems that maybe it wasn't backported in MinGW as well?
I saw the same error in only the MinGW
+ R 4.3
+ Rtools43
build on #6061.
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
@guolinke @shiyu1994 could I get help with a review on this? In addition to the bugfixes and performance improvements in these new versions of these libraries, I think this PR will help with fully testing the R package against R 4.3 and with efforts like #5981 to make the project compatible with C++20. |
Thanks so much @guolinke ! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #3763.
Contributes to #5691.
Proposes updated the projects vendored in here as git submodules to their latest versions:
boostorg/compute
: no change (already on v1.83.0, September 2021)fmtlib/fmt
: fromv8.1.1
(January 2022) tov10.1.1
(August 2023)lemire/fast_double_parser
: fromv0.3.0
(November 2020) tov0.7.0
(December 2022)libeigen/eigen
: no change (already on v3.4.0, August 2021)How I did that
Benefits of this change
Pulls in bugfixes, security patches, performance improvements.
I'm hoping it'll help with R 4.3 support via changes like this: