WIP: [R-package] require lgb.Dataset, remove support for passing 'colnames' and 'categorical_feature' for lgb.train() and lgb.cv() #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing 'feature_name' and 'categorical_feature' to lgb.train() and lgb.cv()
jameslamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6435
Enforces deprecations that have been in
{lightgbm}sinvce v4.4.0:lgb.Datasettodataargument oflgb.cv()colnamesandcategorical_featurearguments fromlgb.train()andlgb.cv()Notes for Reviewers
Still need to do reverse dependency checks
Before this is merged, we should check that it won't break any projects on CRAN that depend on
{lightgbm}. I might propose introducing a comment-triggered CI job we can use for this purpose, maybe with https://github.com/r-lib/revdepcheck.xgboostdid something similar recentlyAs @mayer79 mentioned on #6435. See dmlc/xgboost#10031