Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] Rename cvfolds variable into cvbooster in engine.cv function #6762

Conversation

ClaudioSalvatoreArcidiacono
Copy link
Contributor

@ClaudioSalvatoreArcidiacono ClaudioSalvatoreArcidiacono commented Dec 17, 2024

Change requested by @jameslamb in #5808 (comment).

Renaming the variable into cvbooster would be more correct and it would make it more coherent with the returned result.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thank you!

@jameslamb jameslamb merged commit 4feee28 into microsoft:master Dec 17, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants